-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license header to files that have no header #2469
Conversation
The runtime repository has license headers for tests and files. Currently, the linker repo does not have a license displayed in all files, with most testing files not having any header. Some concern brought by @MichalStrehovsky is that some of these files may precede the acquisition made by Microsoft and in that case is not clear if we can copyright them. |
I'd not be too concerned with copyright for test files, especially if they are small. @mrvoorhe could you comment with explicit approval too? |
I'm perfectly OK adding the license header to everything - makes it simple and consistent. Lines 103 to 105 in 1a6468f
In that case linter would catch missing headers and fail the CI (and running it locally should actually add the header there for you). |
What about files that currently have a different license header for example AssemblyResolver.cs which has a Novell license? |
I guess we will need to involve somebody who understands licensing. The LICENSE.txt in the root doesn't mention Novell at all, it's purely a .NET Foundation license. I assume that we would need to either change the license for the file or add something to the main license. |
I would not touch the files that have existing license headers - see dotnet/runtime#63146 (comment). I don't know if we have existing guidance from CELA on source files that are old, but don't have any licensing header whatsoever. It should be fine to add the header to any files added in the past ~5 years (and it is our policy to have those headers). |
Following CELA guidance we can:
|
Files that still have previous license headers and haven't been modified are:
Files from project:
|
If these files are not modified, then we should keep them as-is. |
That's what the 3PN is for. Here are some good rules:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's probably worth re-doing the changes on top of the latest commit from a fresh state to make sure there are no unrelated changes introduced by accident.
....Tests.Cases.Expectations/Assertions/VerifyAllReflectionAccessPatternsAreHandledAttribute.cs
Outdated
Show resolved
Hide resolved
test/Mono.Linker.Tests/TestCasesRunner/TestReflectionPatternRecorder.cs
Outdated
Show resolved
Hide resolved
5c1ca25
to
9739ff5
Compare
@richlander I think this PR is ready for review, PTAL |
Every commit now is potentially a merge conflict, so it will be nice to merge this as soon as possible to prevent unnecessary rework |
…ginning of the file Some of the files that hold a license from a third party now have the two licenses as header files Linker now uses the sdk format of license header instead of the runtime one Added having the license header as warning in the editor config Added THIRD-PARTY-NOTICES.TXT file to the repo root
6d42017
to
f50b81e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
…ginning of the file (dotnet/linker#2469) Some of the files that hold a license from a third party now have the two licenses as header files Linker now uses the sdk format of license header instead of the runtime one Added having the license header as warning in the editor config Added THIRD-PARTY-NOTICES.TXT file to the repo root Commit migrated from dotnet/linker@4f0d349
This PR adds the following message as header
for files that dont contain any license information