Remove code from iOS that short circuits propagation (#24477)

* Remove code from iOS that short circuits propagation

* - fix

src/Controls/src/Core/Compatibility/Handlers/iOS/FrameRenderer.cs

@@ -207,7 +207,7 @@ protected override void Dispose(bool disposing)
 		public override void SetNeedsLayout()
 		{
 			base.SetNeedsLayout();
-			this.GetSuperViewIfWindowSet()?.SetNeedsLayout();
+			this.Superview?.SetNeedsLayout();
 		}
 
 		[Microsoft.Maui.Controls.Internals.Preserve(Conditional = true)]

src/Controls/tests/TestCases.HostApp/Issues/Issue24434.cs

@@ -0,0 +1,47 @@
+using Microsoft.Maui.Controls.Internals;
+
+namespace Maui.Controls.Sample.Issues
+{
+	[Issue(IssueTracker.Github, 24434, "Modifying a layout while view isn't part of the Window fails to update the layout visually",
+		PlatformAffected.iOS)]
+	public class Issue24434 : NavigationPage
+	{
+		public Issue24434() : base(new TestPage())
+		{
+
+		}
+
+		public class TestPage : ContentPage
+		{
+			public TestPage()
+			{
+				VerticalStackLayout vsl = new VerticalStackLayout();
+
+				vsl.Add(new Button()
+				{
+					Text = "Click me and you should see a label appear beneath me",
+					LineBreakMode = LineBreakMode.WordWrap,
+					AutomationId = "ClickMe",
+					Command = new Command(async () =>
+					{
+						TaskCompletionSource taskCompletionSource = new TaskCompletionSource();
+						vsl.Unloaded += (_, _) =>
+						{
+							vsl.Add(new Label { Text = "Hello, World!", AutomationId = "Success" });
+							taskCompletionSource.TrySetResult();
+						};
+
+						await Navigation.PushAsync(new ContentPage() { Content = new Label() { Text = "I should just disappear" } });
+						await Navigation.PushModalAsync(new ContentPage() { Content = new Label() { Text = "I should just disappear" } });
+
+						await taskCompletionSource.Task.WaitAsync(TimeSpan.FromSeconds(5));
+						await Navigation.PopModalAsync();
+						await Navigation.PopAsync();
+					})
+				});
+
+				Content = vsl;
+			}
+		}
+	}
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24434.cs

@@ -0,0 +1,24 @@
+using NUnit.Framework;
+using UITest.Appium;
+using UITest.Core;
+
+namespace Microsoft.Maui.TestCases.Tests.Issues
+{
+	public class Issue24434 : _IssuesUITest
+	{
+		public Issue24434(TestDevice testDevice) : base(testDevice)
+		{
+		}
+
+		public override string Issue => "Modifying a layout while view isn't part of the Window fails to update the layout visually";
+
+		[Test]
+		[Category(UITestCategories.Layout)]
+		public void ModifyingANonVisibleLayoutWorks()
+		{
+			App.WaitForElement("ClickMe");
+			App.Tap("ClickMe");
+			App.WaitForElement("Success");
+		}
+	}
+}

src/Core/src/Platform/iOS/LayoutView.cs

@@ -11,14 +11,14 @@ public override void SubviewAdded(UIView uiview)
 		{
 			InvalidateConstraintsCache();
 			base.SubviewAdded(uiview);
-			this.GetSuperViewIfWindowSet()?.SetNeedsLayout();
+			this.Superview?.SetNeedsLayout();
 		}
 
 		public override void WillRemoveSubview(UIView uiview)
 		{
 			InvalidateConstraintsCache();
 			base.WillRemoveSubview(uiview);
-			this.GetSuperViewIfWindowSet()?.SetNeedsLayout();
+			this.Superview?.SetNeedsLayout();
 		}
 
 		public override UIView? HitTest(CGPoint point, UIEvent? uievent)

src/Core/src/Platform/iOS/MauiView.cs

@@ -140,7 +140,7 @@ public override void SetNeedsLayout()
 		{
 			InvalidateConstraintsCache();
 			base.SetNeedsLayout();
-			this.GetSuperViewIfWindowSet()?.SetNeedsLayout();
+			this.Superview?.SetNeedsLayout();
 		}
 
 		IVisualTreeElement? IVisualTreeElementProvidable.GetElement()

src/Core/src/Platform/iOS/ViewExtensions.cs

@@ -264,18 +264,10 @@ public static void UpdateBackgroundLayerFrame(this UIView view)
 			}
 		}
 
-		internal static UIView? GetSuperViewIfWindowSet(this UIView? view)
-		{
-			if (view?.Window is null)
-				return null;
-
-			return view.Superview;
-		}
-
 		public static void InvalidateMeasure(this UIView platformView, IView view)
 		{
 			platformView.SetNeedsLayout();
-			platformView.GetSuperViewIfWindowSet()?.SetNeedsLayout();
+			platformView.Superview?.SetNeedsLayout();
 		}
 
 		public static void UpdateWidth(this UIView platformView, IView view)

src/Core/src/Platform/iOS/WrapperView.cs

@@ -240,7 +240,7 @@ public override void SetNeedsLayout()
 		{
 			base.SetNeedsLayout();
 
-			this.GetSuperViewIfWindowSet()?.SetNeedsLayout();
+			this.Superview?.SetNeedsLayout();
 		}
 
 		partial void ClipChanged()