Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow * decompression during Arrange even when target size is smaller than desired size #10768

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Oct 18, 2022

Description of Change

#10073 fixed a bug with measurement on Grid - prior to that, Grid would return greedy measurement values which asked for the entire available space when the Grid had '*' rows or columns.

Part of that fix was the process of "decompressing" the measurement results when arranging the Grid into a space. The measurement step asked for the minimum space necessary for the views inside '*' rows/columns; the arrangement step needed to expand those rows/columns to fill the space given.

However, there was a naive check in the decompression process to determine whether it was necessary, which did not properly account for margins and/or fixed-size containers.

These changes remove the naive check and add an automated test for the situation demonstrated by the control template in #10491.

Issues Fixed

Fixes #10491
fixes #10797
fixes #10301

@wkfry
Copy link

wkfry commented Nov 1, 2022

This is still repro-ing for me in 7.0.100-rc.2.22477.23 (Preview 6).

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
@samhouts samhouts added the fixed-in-7.0.49 Look for this fix in 7.0.49 GA! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-7.0.49 Look for this fix in 7.0.49 GA!
Projects
None yet
4 participants