Design time converters should return TRUE for CanConvertFrom string #10969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chabiss
approved these changes
Oct 27, 2022
mattleibow
approved these changes
Oct 27, 2022
|
@chabiss, @mattleibow do you know how to backport this PR to net7.0 branch? Or how should it flow into net7.0? |
mattleibow
pushed a commit
that referenced
this pull request
Oct 27, 2022
mattleibow
pushed a commit
that referenced
this pull request
Oct 27, 2022
|
As of today, our bot is still being set up so no automagic. But, I cherry picked this to net7 and release a few hours ago and already is building. |
samhouts
added
fixed-in-7.0.49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10968.
Verified by replacing Microsoft.Maui.Controls.DesignTools.dll locally and manually testing repro scenario