Fix MauiIcon ForegroundScale on systems with comma as decimal separator #11690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#11685 Specifying the ForegroundScale with a dot caused an issue on systems with commas as decimal separators. The image got upscaled instead of downscaled on those systems because the ForegroundScale was parsed without passing InvariantCulture as culture info. Because of this, it only worked on systems with a dot as a decimal separator.
ghost
added
the
|
Hey there @AndreKraemer! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
approved these changes
Nov 28, 2022
|
Thanks so much for this PR... I wonder who wrote this code 😉 |
|
/backport to net7.0 |
|
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/3649847088 |
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Specifying the
ForegroundScalewith a dot caused an issue on systems with commas as decimal separators. The image got upscaled instead of downscaled on those systems because theForegroundScalewas parsed without passingInvariantCultureas culture info. Because of this, the existing implementation only worked on systems with a dot as a decimal separator.In order to solve the issue, the InvariantCulture get's now used when parsing
ForegroundScaleIssues Fixed
Fixes #11685