[iOS/Catalyst] Correctly render ContentPage brushes background #11721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
jsuarezruiz
commented
Nov 29, 2022
| @@ -264,14 +265,24 @@ public static void UpdateBackgroundLayerFrame(this UIView view) | |||
|
|
|||
| var layer = view.Layer; | |||
|
|
|||
| UpdateBackgroundLayerFrame(layer, view.Bounds); | |||
There was a problem hiding this comment.
Not in 100% of the cases we will have the background layer as a sublayer of the main one. The main change is here, use recursion to get the background layer.
|
This changes also fixes #10445 on iOS/Catalyst. |
PureWeen
reviewed
Nov 30, 2022
hartez
suggested changes
Dec 1, 2022
|
Thanks @jsuarezruiz for helping to solve this issue. This fix is going to be amazing due to it will help us to reduce the layers in our apps just to render a gradient in the app screens. 👍🏻 . This will also help to increase the performance of our apps by reducing the layers 💯 |
rmarinho
approved these changes
Feb 1, 2023
hartez
approved these changes
Feb 1, 2023
Eilon
removed
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Correctly render ContentPage brushes background on iOS/Catalyst.
Issues Fixed
Fixes #11714