-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internalize MessagingCenter #12582
Merged
Merged
Internalize MessagingCenter #12582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
approved these changes
Jan 18, 2023
mattleibow
approved these changes
Jan 23, 2023
It appears there is a memory leak every time you do: await DisplayAlert("Done!", "Done!", "Ok"); maui/src/Controls/src/Core/Page.cs Lines 239 to 244 in 918d1ce
Is this a known issue with |
That may have been one of the reasons we want to remove it. But probably we just want to reduce unnecessary complexity. I got this one that needs my tests fixed #12910 |
mattleibow
added a commit
that referenced
this pull request
Aug 16, 2023
This reverts commit f9be2d1. # Conflicts: # src/Controls/src/Core/MessagingCenter.cs # src/Controls/src/Core/Properties/AssemblyInfo.cs # src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt
mattleibow
added a commit
that referenced
this pull request
Aug 17, 2023
This reverts commit f9be2d1. # Conflicts: # src/Controls/src/Core/MessagingCenter.cs # src/Controls/src/Core/Properties/AssemblyInfo.cs # src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt
rmarinho
pushed a commit
that referenced
this pull request
Aug 19, 2023
This reverts commit f9be2d1. # Conflicts: # src/Controls/src/Core/MessagingCenter.cs # src/Controls/src/Core/Properties/AssemblyInfo.cs # src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
Look for this fix in 8.0.0-preview.1.7762!
label
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
fixed-in-8.0.0-preview.1.7762
Look for this fix in 8.0.0-preview.1.7762!
needs-breaking-change-doc-created
t/breaking 💥
t/housekeeping ♻︎
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
MessagingCenter
was deprecated for net7, let's make it internal for net8 so we are free to remove/replace it whenever we want after that.