Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix issues invalidating the Background of some controls #12773

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jan 19, 2023

Description of Change

Fix issues invalidating the Background of some Windows controls.

fix-brush-windows

Issues Fixed

Fixes #12749

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Jan 19, 2023
@@ -155,6 +155,8 @@ internal static void TryUpdateResource(this FrameworkElement element, object new
if (rd?.ContainsKey(key) ?? false)
rd[key] = newValue;
}

element?.RefreshThemeResources();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and similar changes is the main change that fixes the issue.

@rmarinho rmarinho merged commit 1f19a8a into main Jan 26, 2023
@rmarinho rmarinho deleted the fix-12749 branch January 26, 2023 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picker and Switch BackgroundColor properties are not updated from ViewModel
3 participants