Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add shell pages via controller instead of handler (#13332)" #13465

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

PureWeen
Copy link
Member

Description of Change

Adding the View that's part of ContainerViewController instead of the PlatformView causes the layout to be wrong.

@jfversluis jfversluis merged commit fd53d11 into main Feb 21, 2023
@jfversluis jfversluis deleted the revert_adding_view_from_pagecontroller branch February 21, 2023 08:10
@Redth
Copy link
Member

Redth commented Feb 21, 2023

/backport to release/8.0.1xx-preview1

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-preview1: https://github.com/dotnet/maui/actions/runs/4234011534

tj-devel709 pushed a commit to tj-devel709/maui that referenced this pull request Feb 21, 2023
tj-devel709 pushed a commit to tj-devel709/maui that referenced this pull request Feb 21, 2023
@samhouts samhouts added area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/iOS 🍎 labels Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.2.7871 Look for this fix in 8.0.0-preview.2.7871! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-8.0.0-preview.2.7871 Look for this fix in 8.0.0-preview.2.7871! platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants