Merge branch 'release/8.0.1xx-sr2' into main
#20371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PureWeen
commented
Feb 5, 2024
•
PureWeen
commented
- Fixes: [MAUI][.NET8] ‘Review’ module jumps repeatedly when editing recipe page. #20126
* Account for margins on sizes returned from Editor * - add tests for margin and desired size * - recalculate editor if users changes height/width/margin * - remove previous margin * Update Editor.cs * - add additional tests and scenarios to check for changing dimensions * - fix tests for iOS * - fix view test timing and accuracy * - only insert middle layer view if root view is MauiView * - offset from safe areas
Redth
approved these changes
Feb 5, 2024
|
Failing tests on windows core are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.