-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fixed border inside frame not rendering #20974
Conversation
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
97ec623
to
9d50c37
Compare
{ | ||
if (child is IShape) | ||
{ | ||
((VisualElement)child).IsVisible = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share more details about this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz When we set the property IsVisible
to false
then the parent layout doesn't consider this shape when calculating the required size for its content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just set DisableLayout
to true?
maui/src/Controls/src/Core/Layout.cs
Line 623 in 8482028
if (Width <= 0 || Height <= 0 || !LogicalChildrenInternal.Any() || !IsVisible || !IsPlatformStateConsistent || DisableLayout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PureWeen I tried but it doesn't work:
if (content is Border border)
{
var shape = border.LogicalChildrenInternal.FirstOrDefault(child => child is IShape);
if (shape is VisualElement visualElement)
{
visualElement.DisableLayout = true; // doesn't work
visualElement.IsVisible = false; // works
}
}
Probably #20944 is also related with these changes. |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
replaced by #23124 |
Issues Fixed
Fixes #18526
Fixes #18755
Fixes #20944