Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RefreshView Tests #23181

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Enable RefreshView Tests #23181

merged 7 commits into from
Jul 1, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jun 21, 2024

Description of Change

Move disabled device tests to appium. These tests require UI interactions which we can't really recreate from the device tests.

I tested removing the changes made in https://github.com/dotnet/maui/pull/17062/files#diff-2d87a80df0a7988d1f249910b23fc95a072e4df4bd0c92c18ec6f03517cf35b7R153-R158 to validate that the Appium tests I added are doing something useful and they are :-) If you comment out the code in #17062 the android app just crashes.

Issues Fixed

Fixes #17114

@PureWeen PureWeen marked this pull request as ready for review June 21, 2024 22:35
@PureWeen PureWeen requested a review from a team as a code owner June 21, 2024 22:35
@PureWeen PureWeen marked this pull request as draft June 24, 2024 18:11
@PureWeen PureWeen marked this pull request as ready for review June 24, 2024 22:40
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a category? And probably a rebase with the whole folder rename thing?

@jfversluis jfversluis added the area-testing Unit tests, device tests label Jun 26, 2024
@PureWeen PureWeen requested a review from jfversluis June 27, 2024 00:21
@PureWeen
Copy link
Member Author

/azp run

Copy link

Pipelines were unable to run due to time out waiting for the pull request to finish merging.

@PureWeen
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member Author

/rebase

@PureWeen PureWeen enabled auto-merge (squash) July 1, 2024 14:55
@PureWeen PureWeen disabled auto-merge July 1, 2024 17:51
@PureWeen PureWeen merged commit 2a9f9fd into main Jul 1, 2024
47 checks passed
@PureWeen PureWeen deleted the reenable_refreshview_tests branch July 1, 2024 17:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
@samhouts samhouts added fixed-in-8.0.70 fixed-in-net9.0-nightly This may be available in a nightly release! labels Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests fixed-in-8.0.70 fixed-in-net9.0-nightly This may be available in a nightly release!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tests] Enable RefreshView device tests
3 participants