-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable RefreshView Tests #23181
Merged
Merged
Enable RefreshView Tests #23181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
reenable_refreshview_tests
branch
from
June 24, 2024 21:28
be9d935
to
fbbf789
Compare
jfversluis
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a category? And probably a rebase with the whole folder rename thing?
PureWeen
force-pushed
the
reenable_refreshview_tests
branch
from
June 27, 2024 00:21
4bf6415
to
416379c
Compare
/azp run |
Pipelines were unable to run due to time out waiting for the pull request to finish merging. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/rebase |
github-actions
bot
force-pushed
the
reenable_refreshview_tests
branch
from
June 29, 2024 16:07
d78b9f8
to
73a644d
Compare
samhouts
added
fixed-in-8.0.70
fixed-in-net9.0-nightly
This may be available in a nightly release!
labels
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-testing
Unit tests, device tests
fixed-in-8.0.70
fixed-in-net9.0-nightly
This may be available in a nightly release!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Move disabled device tests to appium. These tests require UI interactions which we can't really recreate from the device tests.
I tested removing the changes made in https://github.com/dotnet/maui/pull/17062/files#diff-2d87a80df0a7988d1f249910b23fc95a072e4df4bd0c92c18ec6f03517cf35b7R153-R158 to validate that the Appium tests I added are doing something useful and they are :-) If you comment out the code in #17062 the android app just crashes.
Issues Fixed
Fixes #17114