Generate the Android 7 round app icon #23276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
area-single-project
github-actions
bot
force-pushed
the
dev/android-round-icon
branch
from
77f0878
to
79d6d02
Compare
|
/rebase |
github-actions
bot
force-pushed
the
dev/android-round-icon
branch
from
52fbcd3
to
40c4e35
Compare
mattleibow
commented
Jul 26, 2024
Comment on lines
+86
to
+91
| if (GetClipPath(dpi, canvasSize, unscaledCanvasSize) is { } clipPath) | ||
| { | ||
| canvas.Clear(SKColors.Transparent); | ||
|
|
||
| canvas.ClipPath(clipPath, antialias: true); | ||
| } |
There was a problem hiding this comment.
This is the real code change, if there is a clip path attached to the "dpi" then we clip to that first.
Comment on lines
+70
to
+75
| // legacy round for Android 7 | ||
| new DpiPath("mipmap-mdpi", 1.0m, "_round", size: new SKSize(48, 48), clip: ClipShape.Circle), | ||
| new DpiPath("mipmap-hdpi", 1.5m, "_round", size: new SKSize(48, 48), clip: ClipShape.Circle), | ||
| new DpiPath("mipmap-xhdpi", 2.0m, "_round", size: new SKSize(48, 48), clip: ClipShape.Circle), | ||
| new DpiPath("mipmap-xxhdpi", 3.0m, "_round", size: new SKSize(48, 48), clip: ClipShape.Circle), | ||
| new DpiPath("mipmap-xxxhdpi", 4.0m, "_round", size: new SKSize(48, 48), clip: ClipShape.Circle), |
There was a problem hiding this comment.
Just these have a clip shape.
rmarinho
approved these changes
Jul 29, 2024
samhouts
added
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes the case where Android 7 is very different:
This means that specifically for Android 7, the round icons are PNG files but for Android 8 they are adaptive icons.
Issues Fixed
Fixes #23178