Shell BackButtonBehavior improvement #23466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
added
platform/iOS 🍎
area-controls-shell
kubaflo
requested review from
jfversluis
and removed request for
mattleibow and
jsuarezruiz
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Jul 6, 2024
| { | ||
| Items.Add(new ContentPage()); | ||
| Routing.RegisterRoute(nameof(DetailPage),typeof(DetailPage)); | ||
| GoToAsync(nameof(DetailPage)); |
There was a problem hiding this comment.
I don't think we need to register a route here.
Maybe just this to keep it simple
Items.Add(new ContentPage());
Navigation.PushAsync(new DetailPage());
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Jul 6, 2024
samhouts
added
fixed-in-8.0.70
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #23424
Fixes #5195
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-06.at.13.38.33.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-06.at.13.51.31.mp4