Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Add accessibility label to the menu button #23762

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

tj-devel709
Copy link
Contributor

Description of Change

The flyout menu button on Catalyst does not have a label on the Accessibility Inspector. This small change allows the accessibility inspector to show the hamburger button is a menu button.

MenuButtonAccessibility.mov

See that the flyout menu label changes to "Menu" when we are on the root page.

Issues Fixed

Fixes:

@tj-devel709 tj-devel709 added the t/a11y Relates to accessibility label Jul 22, 2024
@tj-devel709 tj-devel709 requested a review from a team as a code owner July 22, 2024 17:49
@PureWeen
Copy link
Member

/rebase

@github-actions github-actions bot force-pushed the dev/TJ/AddMenuAccessibilityButton branch from 81d5801 to 9ed07c8 Compare July 23, 2024 14:51
@PureWeen PureWeen enabled auto-merge (squash) July 23, 2024 23:16
@PureWeen PureWeen merged commit d38ca87 into main Jul 24, 2024
97 checks passed
@PureWeen PureWeen deleted the dev/TJ/AddMenuAccessibilityButton branch July 24, 2024 11:40
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-8.0.80 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.80 fixed-in-net9.0-nightly This may be available in a nightly release! t/a11y Relates to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants