Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] update AOT profile for servicing #23765

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[android] update AOT profile for servicing #23765

merged 1 commit into from
Jul 23, 2024

Conversation

jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Jul 22, 2024 •
edited
Loading

Tested with .NET 8, it appears that the amount of MAUI code changes have made the AOT profile slightly out of date.

Just updating it, and testing a dotnet new maui project on a Pixel 7:

Before:
Average(ms): 444.5
Std Err(ms): 4.19324854180304
Std Dev(ms): 13.2602161872774
After:
Average(ms): 434.8
Std Err(ms): 3.77359245282264
Std Dev(ms): 11.933147112141

I also fixed some NRT warnings in the app used for recording profiles.

@jonathanpeppers
[android] update AOT profile for servicing
bd3881a 
Tested with .NET 8, it appears that a resonable number of MAUI code
changes have made the AOT profile slightly out of date.

Just updating it, and testing a `dotnet new maui` project on a Pixel 7:

    Before:
    Average(ms): 444.5
    Std Err(ms): 4.19324854180304
    Std Dev(ms): 13.2602161872774
    After:
    Average(ms): 434.8
    Std Err(ms): 3.77359245282264
    Std Dev(ms): 11.933147112141

I also fixed some NRT warnings in the app used for recording profiles.
@jonathanpeppers jonathanpeppers added platform/android 🤖 t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) labels Jul 22, 2024
@jonathanpeppers jonathanpeppers requested a review from a team as a code owner July 22, 2024 19:17
@rmarinho rmarinho merged commit d5eab86 into dotnet:main Jul 23, 2024
95 of 97 checks passed
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-8.0.80 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
fixed-in-8.0.80 fixed-in-net9.0-nightly This may be available in a nightly release! platform/android 🤖 t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanpeppers @rmarinho @samhouts