Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Android LoadImageFromFont benchmark and enable verbose Glide logging #24033

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add Android LoadImageFromFont benchmark and enable verbose Glide logging #24033

merged 1 commit into from
Aug 20, 2024

Conversation

albyrock87
Copy link
Contributor

@albyrock87 albyrock87 commented Aug 6, 2024 •
edited
Loading

Description of Change

Adds a benchmark for LoadImageFromFont on Android platform.
Also enables VERBOSE logging of Glide if requested via adb.

See #22757 (comment)

@albyrock87 albyrock87 requested a review from a team as a code owner August 6, 2024 11:19
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 6, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

albyrock87
albyrock87 commented Aug 6, 2024
View reviewed changes
src/Core/tests/Benchmarks.Droid/Benchmarks.Droid.csproj
@@ -28,7 +28,7 @@
<Using Include="BenchmarkDotNet.Order" />
<Using Include="BenchmarkDotNet.Running" />
<PackageReference Include="BenchmarkDotNet" Version="0.13.10" />
<PackageReference Include="Xamarin.Android.Glide" Version="4.14.2.1" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version was not in sync with the one we use on all other projects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put the entry here across the repo?

Then you could just put <PackageReference Include="Xamarin.Android.Glide" /> without the Version across the repo.

Copy link
Contributor Author

@albyrock87 albyrock87 Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I found something better which is already used in the solution $(_XamarinAndroidGlideVersion).

maui/eng/Versions.props

Line 92 in 363b626

<_XamarinAndroidGlideVersion>4.15.1.2</_XamarinAndroidGlideVersion>

jonathanpeppers
jonathanpeppers reviewed Aug 9, 2024
View reviewed changes
src/Core/tests/Benchmarks.Droid/Benchmarks.Droid.csproj
@@ -28,7 +28,7 @@
<Using Include="BenchmarkDotNet.Order" />
<Using Include="BenchmarkDotNet.Running" />
<PackageReference Include="BenchmarkDotNet" Version="0.13.10" />
<PackageReference Include="Xamarin.Android.Glide" Version="4.14.2.1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put the entry here across the repo?

Then you could just put <PackageReference Include="Xamarin.Android.Glide" /> without the Version across the repo.

src/Core/tests/Benchmarks.Droid/ImageBenchmarks.cs Outdated Show resolved Hide resolved
@albyrock87 albyrock87 changed the title [Chore] Add Android LoadImageFromFont benchmark Add Android LoadImageFromFont benchmark and enable verbose Glide logging Aug 12, 2024
albyrock87
albyrock87 commented Aug 12, 2024
View reviewed changes
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/glide/GlideLogging.java
return IS_VERBOSE_LOGGABLE;
}

public static void v(String message) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this in the future to enhance our java glide-related logging.

@PureWeen
Copy link
Member

/azp run

1 similar comment
@PureWeen
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen mentioned this pull request Aug 19, 2024
Closed
@PureWeen PureWeen enabled auto-merge (squash) August 19, 2024 23:15
@PureWeen PureWeen merged commit ab55e36 into dotnet:main Aug 20, 2024
97 checks passed
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@PureWeen PureWeen PureWeen approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
community ✨ Community Contribution fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albyrock87 @PureWeen @jonathanpeppers @samhouts