[Windows] Fix memory leak w/ main window #24176
Merged
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foda
added
platform/windows 🪟
memory-leak 💦
Foda
changed the title
Foda
commented
Aug 12, 2024
| @@ -87,6 +87,9 @@ private void OnClosedPrivate(object sender, UI.Xaml.WindowEventArgs args) | |||
| { | |||
| OnClosed(sender, args); | |||
|
|
|||
| Activated -= OnActivated; | |||
There was a problem hiding this comment.
After a bunch of trial and error, this was the solution to getting the weak reference to be marked not-alive.
|
hi, if this fix pass this issue sample app? #24140 |
jfversluis
approved these changes
Aug 13, 2024
rmarinho
approved these changes
Aug 13, 2024
samhouts
added
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.1.24453.9
and removed
fixed-in-net9.0-nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix memory leak w/ main window by unsubscribing to events.
Issues Fixed
Fixes #24102