Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve design type converters #9447

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Improve design type converters #9447

merged 2 commits into from
Aug 16, 2022

Conversation

etvorun
Copy link
Contributor

@etvorun etvorun commented Aug 15, 2022

Added design type converters (used by VS when parsing XAML):

  • GridLengthDesignTypeConverter
  • GridLengthCollectionDesignTypeConverter
    Fixed bugs in ColorDesignTypeConverter

@dnfadmin
Copy link

dnfadmin commented Aug 15, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@etvorun etvorun marked this pull request as ready for review August 16, 2022 16:22
@etvorun etvorun merged commit 02f0b53 into main Aug 16, 2022
@etvorun etvorun deleted the dev/evgenyt/fix_design_converters branch August 16, 2022 17:53
@etvorun etvorun mentioned this pull request Oct 17, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen

@drasticactions drasticactions Awaiting requested review from drasticactions

@Redth Redth Awaiting requested review from Redth

Assignees
No one assigned
Labels
fixed-in-7.0.0-rc.1.6683 layout-grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etvorun @dnfadmin @StephaneDelcroix @samhouts