Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use 'Configuration' property #5330

Closed
wants to merge 1 commit into from
Closed

Always use 'Configuration' property #5330

wants to merge 1 commit into from

Conversation

Nirmal4G
Copy link
Contributor

@Nirmal4G Nirmal4G commented May 2, 2020

If we set ConfigurationName to something else, the debug builds break!

If we set 'ConfigurationName' to something else, the debug builds break
@Nirmal4G
Copy link
Contributor Author

Nirmal4G commented May 2, 2020

@rainersigwald Split from #5238

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about this in team triage today. @Forgind figured out that it's likely a breaking change.

Consider a case where you have a custom configuration that is "like debug". For instance, our own Debug-MONO configuration. You can then set ConfigurationName to Debug for that to get the default "like Debug behavior".

We just took a quick look through our internal history and ConfigurationName was introduced just before MSBuild (1.0!) RTM. The commit notes aren't super helpful, but we expect it was because of that case.

Thanks for trying to clean this up! But I don't think we can take this.

@Nirmal4G
Copy link
Contributor Author

For instance, our own Debug-MONO configuration. You can then set ConfigurationName to Debug for that to get the default "like Debug behavior".

This should be in the docs. I was using it for that exact purpose but other way around. Thanks for clarifying.

@Nirmal4G Nirmal4G deleted the hotfix/fix-configuration-ref branch May 25, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants