-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unix: don't spawn 'uname -m' when we can get the ProcessorArchitecture from the runtime. #5897
Conversation
…e from the runtime.
Most commands I run with dotnet cli that involve msbuild spawn one or more For example:
This change will eliminate those. |
{ | ||
ProcessorArchitectureType = ProcessorArchitectures.ARM; | ||
} | ||
else if (arch.StartsWith("aarch64", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added aarch64
case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
PR build hang was #5520, I'll rerun. |
No description provided.