Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization neglected to include condition #5927

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Optimization neglected to include condition #5927

merged 2 commits into from
Dec 3, 2020

Conversation

Forgind
Copy link
Member

@Forgind Forgind commented Dec 2, 2020 •
edited
Loading

Fixes #5766

Introduced by #5350

@rainersigwald
Copy link
Member

Looks very plausible as the solution. 🤦🏻‍♂️

@Forgind
Copy link
Member Author

Forgind commented Dec 2, 2020

Tested it, and everything checked out. Upgrading to PR.

@Forgind Forgind marked this pull request as ready for review December 2, 2020 19:21
benvillalobos
benvillalobos approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Forgind Forgind merged commit cd29721 into dotnet:master Dec 3, 2020
@Forgind Forgind deleted the fix-skipped-condition branch December 3, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@benvillalobos benvillalobos benvillalobos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditioned ItemGroup executes Remove sometimes when it shouldn't
3 participants
@Forgind @rainersigwald @benvillalobos