Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incrementalism when suppressed: #9717

Merged
merged 5 commits into from
Jan 17, 2024

Commits on Dec 16, 2023

  1. Fix incrementalism when suppressed:

    - Previously when going from unsuppressed -> suppressed we cleared certan caches
    - This meant that when going from suppressed -> unsuppressed we were always re compiling every razor file
    - Now instead, we produce nothing *until* the generator is unsuppressed, after which we just say that whatever is in the caches is up to date if we're suppressed.
    - This ensures no downstream processing takes place when the generator is suppressed, but there is still data to incrementally update when unsuppressed
    - We still remove the generated files at the last step when suppressed, so there is no output, but don't have to recompile anything to get the output back again.
    chsienki committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    2db31c1 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Add comment

    chsienki committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a841229 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    bb54da2 View commit details
    Browse the repository at this point in the history
  2. Update src/Compiler/Microsoft.NET.Sdk.Razor.SourceGenerators/Incremen…

    …talValueProviderExtensions.cs
    
    Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
    chsienki and jjonescz committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a31a8f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d56659 View commit details
    Browse the repository at this point in the history