ExtractMethod isn't aware of nullability

[jcouv]

FYI @dpoeschl

Note this can only be fixed once the compiler exposes public APIs for nullability of expressions (see workitems list)

[CyrusNajmabadi]

Note this can only be fixed once the compiler exposes public APIs for nullability of expressions (see workitems list)

This somewhat worries me. Is each feature going to have to know about these types? That seems... not good. Shouldn't this just fall out, just like any other type change (like adding tuples)?

[jasonmalinowski]

Note that this one is somewhat special: if there's a variable that's being assigned throughout a method and we're lifting it to the other method, we need to declare it nullable if any assignment to it could be nullable. I'm not quite sure what the right way to do this is -- we could just walk the assignments and check if it's nullable being assigned. We may also need a special compiler API although maybe not.

[jasonmalinowski]

Fixed by #37851.