IDE Test Pass for Nullable Reference Types

[dpoeschl]

• ✅ = Tested & Approved (possibly with linked bugs)
• ❌ = Merge blocking
• 🚧 = Non-blocking bugs
• 🆗 = Issue has been fixed
• 🆓 = No expected impact
• ❓ = Open question

¹ Feature updated by compiler team, with appropriate unit tests.

² Feature requires more complete testing by IDE team.

Product Features

Core Scenarios in Editing, Navigating, and Viewing

Category	Feature/Description	C# Signoff/Notes	VB Signoff/Notes	F# Signoff/Notes
Enable/Disable	⏩ Feature Flags To completely enables/disable new compiler features in the compiler & IDE	✅		N/A
Typing	⏩ General Typing - Type and paste new constructs - Nothing interferes with verbatim typing	✅
	🔍 ⏩ Completion - Typing new keyword/construct names - Dotting off of new constructs - Matching part of the identifier is highlighted (including word prefix matches) [Visual Studio 2015 Update 1] - Target type preselection [Visual Studio 2017] IntelliSense filtering [Visual Studio 2017]	Fixed #31171 ✅
	⏩ Formatting - Spacing in and around new constructs - Spacing options - Format Document command Tools > Options settings should be respected	Verified #31241 ✅
	⏩ Automatic Brace Completion (C# only) - Auto-insert close brace - Shift+Enter commit of IntelliSense and any pending brace completion sessions (Known issue: #18065)	does not apply		N/A
	⏩ Indentation - Typing Enter in an unfinished statement indents the next line	does not apply	no special logic needed
Navigating	🔍 ⏩ Go To Definition - F12 from callsites to definition - Ctrl+click [Visual Studio 2017 version 15.4]	#30327
	⏩ Go To Implementation - Ctrl+F12 to jump from virtual members to their implementations - Jump from inheritable types to their implementations	#37251 filed to add tests but core feature will work		N/A
	🔍 ⏩ Find All References - Lists references to a symbol in "Find Symbol Results" window - Shows results in hierarchy grouped by definition [Visual Studio 2015] - Results should be groupable/filterable/classified appropriately [Visual Studio 2017] - Find All References on literals [Visual Studio 2017 version 15.3]	Works, will add tests in #37174
Viewing	🔍 ⏩ Colorization - Keywords, literals, and identifiers colored appropriately in code - Colors should theme appropriately - The "Blue Theme (Additional Contrast)" should have sufficiently dark colors	Existing operator so no new work, but #37175 will track optional feature work.
	⏩ Error Squiggles - Squiggles appear as expected on reasonable spans	✅

Code Transformations

Category	Feature/Description	C# Signoff/Notes	VB Signoff/Notes	F# Signoff/Notes
Refactoring with UI	🔍 Inline Rename (with UI) - Dashboard shows correct information - Highlighted spans are updated appropriately - Rename operation updates the correct set of symbols	✅
	🔍 Change Signature (with UI) - Updates all direct & cascaded definitions/callsites - Shows appropriate signature & parameter previews in UI - Reorder and Remove in the same session [Visual Studio 2015]	#30315		N/A
	🔍 Extract Interface (with UI) - Generated Interface has expected shape - UI shows appropriate method previews	#37176 to track fixing UI -- trivial fix. Actual feature works modulo #37177		N/A
	Generate Type (with UI) - Dialog gives all valid options	#30316		N/A
	Generate Overrides [Visual Studio 2017 version 15.3]	#37179 to track UI issue only.		N/A
Refactorings	Rename Tracking - Tracking span tracks & dismisses as expected - Invokable from references [Visual Studio 2015]	does not apply		N/A
	🔍 Extract Method - Extracted method has the expected signature - All arguments/return values handled correctly - Extracted code block is reasonable - Automatically starts Inline Rename	#30314	#30314	N/A
	Introduce Variable - Introduced variable has the expected signature and initializer expression - "Introduce for All" correctly finds dupes	#30318		N/A
	Inline Temporary Variable - Inlined values are appropriately expanded/reduced			N/A
	Organize Usings - Honors "Place 'System' namespace first" option			N/A
	Convert Get* Methods to Properties Add Description			N/A
	🔍 Encapsulate Field - Select a field and convert it to a property backed by the field - Try selecting multiple fields at once			N/A
	Modifier Ordering [Visual Studio 2017 version 15.5]	doesn't apply		N/A
	Convert ReferenceEquals to is null [Visual Studio 2017 version 15.5]			N/A
	Add Missing Modifiers [Visual Studio 2017 version 15.5]	does not apply		N/A
	Convert Lambda to Local Function [Visual Studio 2017 version 15.5]	#30322		N/A
	Move Declaration Near Reference [Visual Studio 2017 version 15.5]			N/A
	Introduce Pattern Matching [Visual Studio 2017 version 15.5]			N/A
	Simplify Inferred Tuple Names [Visual Studio 2017 version 15.5]	Requires C# 7.1 or greater		N/A
	Convert keyword and symbol references to doc comment tags [Visual Studio 2017 version 15.5]			N/A
Fixes	Add Using - Triggers on appropriate constructs - Including NuGet references - Including Referenced Assemblies - Includes spelling fixes
	Generate Local - Select an expression and introduce a local variable to represent it - This should start an Inline Rename session	#30318		N/A
	Generate Field - Select an expression and introduce a field to represent it - This should start an Inline Rename session	#30318		N/A
	Generate Method/Constructor - Call a nonexistent method or constructor to generate it from its usage - Generated method has the expected signature and accessibility - Add parameter to existing constructor from callsite [Visual Studio 2017 version 15.3]	#30319		N/A
	Generate Constructor from members - Select fields/properties to generate a constructor accepting corresponding arguments - Generated constructor has the expected signature and accessibility			N/A
	Implement Interface - Only missing methods added - All added methods have the expected signature and accessibility	#30324		N/A
	Implement IDisposable - Implement IDisposable and you should see a large block of code properly implementing that particular interface	the implemented pattern adds no reference-typed anything so no concerns		N/A
	Implement Abstract Class - Inherit from an abstract class, and you should be able to auto-generate all of the missing members	#30324		N/A
	Remove Unused Variables [Visual Studio 2017 version 15.3]	doesn't apply		N/A
	Remove Unused Usings	doesn't apply
	Sort Usings	doesn't apply		N/A
	Convert Get Methods to Properties - Name a method GetStuff and convert it to a property called Stuff	#37181		N/A
	Make Method Async/Sync - Add an await to a synchronous method, you should be offered to add the async keyword - Remove all await keywords from an async method, you should be offered to remove the async keyword	#30325		N/A
	Use Object Initializer Over Property Assignment - Create a new instance of a type and then assign each of its properties on subsequent lines - You should be offered to convert that to an object initializer	tested and works		N/A
	Insert Digit Separators [Visual Studio 2017 version 15.3]	does not apply		N/A
Code Gen	🔍 Snippets - Tab completion, presence in completion list - Insertion via Snippet Picker UI (Ctrl + K, Ctrl + X) or (Ctrl + K, Ctrl + S) - (VB) Snippet Picker UI via ?<Tab> - (VB) Special snippet completion list (p?<esc><tab>)	does not apply		N/A
	Event Hookup on Tab (C# only) - Type "+=" after an event name and QuickInfo shows - Invoking should pick good name & launch Inline Rename	#37013	N/A	N/A
	End Construct Generation (VB only) - Type Sub Test() and hit enter, the End Sub should be generated automatically	N/A		N/A
	Automatic End Construct Update (VB only) - Type Sub Test() and End Sub, changing Sub to Function in either one should update the other	N/A		N/A
	Spell checking - Type a name that's close to a variable name but off by a character or two - Lightbulb should have option to fix up the spelling - Includes type names that will require a using	does not apply		N/A
	Move type to file - Lightbulb to move type to another file when the type name doesn't match the filename - Option to change the file name if the type doesn't match the file name			N/A
	Convert between properties and Get methods - Offers to change a method named GetStuff to a property named Stuff	#37181		N/A
	Convert auto property to full property [Visual Studio 2017 version 15.5]	#37182		N/A
	Add missing cases Use a switch on a strict subset of an Enum's members - It should offer to generate the rest of the cases	n/a		N/A
	Add null checks for parameters [Visual Studio 2017 version 15.3]	#37067		N/A
	Change base for numeric literals [Visual Studio 2017 version 15.3]	does not apply		N/A
	Convert if to switch [Visual Studio 2017 version 15.3]	doesn't apply		N/A
	Resolve git merge conflicts [Visual Studio 2017 version 15.3]	does not apply		N/A
	Add argument name [Visual Studio 2017 version 15.3	does not apply		N/A
	Fade and remove unreachable code [Visual Studio 2017 version 15.5]	does not apply		N/A
	Add missing file banner [Visual Studio 2017 version 15.5]	does not apply		N/A
	Deconstruct tuple declaration [Visual Studio 2017 version 15.4]	works fine		N/A

IDE Features

Category	Feature/Description	C# Signoff/Notes	VB Signoff/Notes	F# Signoff/Notes
General	Signature Help - Overloads shown with appropriate, colorized signature	confirmed working
	Quick Info - Hover on identifiers - On completion list items	implemented by #36731
	🔍 Outlining - Make sure outlining is enabled under options - Define a method and expect to see a collapsible region around the method definition - Make sure collapse and expand work	doesn't apply
	Brace Matching (C# only) - Highlights matching brace token, if caret is on an open or close brace. - Hovering on a close brace shows the code around the open brace	doesn't apply	N/A	N/A
	Highlight References - Ensure "Highlight references to symbol under cursor" is enabled in options - If caret is on an identifier, all references to that identifier in the active document should be highlighted - We also show related keywords, so placing the caret on a return should show the other returns, if should show elses, try shows catches and finallys, etc. - Should be able to navigate between highlighted references with Ctrl+Shift+Up/Down	doesn't apply
	🔍 Peek Press Alt + F12 after placing the cursor on a predefined Type or predefined member and expect to see to a temporary window showing the appropriate definition	#30326 (no output)
	🔍 Navigation Bars - Open some existing source files, make sure you can navigate around the file choosing classes or methods. - Switch between project contexts - In VB, the NavBar can do code generation for events and for New/Finalize methods	#37183
	Metadata As Source - Press F12 on a predefined type and expect the cursor to move the predefined type definition inside a Metadata-As-Source Generated document. - Expect to see the xml doc comments collapsed above the method.	#30327		N/A
	Navigate to Decompiled Source [Visual Studio 2017 version 15.6 Preview 2] - Set the option at Tools -> Options -> Text Editor -> C# -> Advanced -> Enable navigation to decompiled sources (experimental) - F12 on a type defined in metadata - You should see decompiled method bodies, not just declarations	#37184		N/A
	🔍 Navigate To - Place caret on a user defined Type reference and press "ctrl + ," - This should list the User Defined Type in the drop down on the Upper Right corner of the editor and selecting this item will move the cursor to the User Reference Definition - Filters per kind of symbol [Visual Studio 2017] - Results should be sorted as follows: [Visual Studio 2017 version 15.6 Preview 4] Expand for details TODO	doesn't apply
	Go to Next/Previous Method - Edit.NextMethod and Edit.PreviousMethod should work - You may need to set up keyboard bindings for these commands under Tools > Options > Environment > Keyboard	doesn't apply		N/A
	Solution Explorer Pivots - Define a Type and some members in a sample Document. - Expand the Document listed in the Solution Explorer window and expect to see the Type and Members defined - Right-click types and try Base Types / Derived Types / Is Used By / Implements - Right-click methods and try Calls / Is Called By / Is Used By / Implements	doesn't apply		N/A
	Call Hierarchy - Place the caret over a method, right click & select View Hierarchy - This should open the "Call Hierarchy window" listing the methods that call the original method and also the callsites within each calling method.			N/A
	🔍 Code Lens - Make sure Code Lens is enabled from the options. Look for an adornment on top of each method declaration with lists the number of references for that method, last time someone modified the method, who modified the method and other information	does not apply		N/A
	Project System - Open/close a project - Add/remove references - Unload/reload projects - Source Control integration (adding references checks out projects, etc.)	does not apply
	Debugger IntelliSense - Hit a breakpoint (or step) and verify that there's IntelliSense in the Immediate Window (C#, VB) - Type an expression, and hit enter. Verify it's evaluated. Type another expression. IntelliSense should still work. - (VB) there should be IntelliSense if you type "?" followed by an expression (eg, the text of the line in the window is "?foo") - Hit a breakpoint (or step) and verify that there's IntelliSense in the Watch Window - Hit a breakpoint (or step) and verify that there's IntelliSense in the Quick Watch Window - Verify intellisense in the Conditional Breakpoint view - Verify each of the above scenarios after hitting f5 and hitting another breakpoint, and after stepping	tested and works
	Breakpoint Spans - The span highlighted when a breakpoint is set should be logical	does not apply
	Code Model / Class Designer - Right click a file in Solution Explorer & choose View Class Diagram. - This shows the "Class Details" window where you can add/remove members, change their type/accessibility/name, parameter info, etc.	#37185		N/A
	Object Browser / Class View - Open object browser and classview and verify that project contents are represented live. - Should be able to invoke find all references, navigate to the definition, and do searches.	#37185		N/A
	Lightbulb - Should work with Ctrl+. and the right-click menu - Should include a diff view - Should include options to fix all in Document/Project/Solution, and to Preview Changes Varying icons for lightbulb items [Visual Studio 2017 version 15.4]	not applicable (directly)
	Line Separators - Turn the option on under Tools > Options - Ensure there's a line between methods.	does not apply		N/A
	Indent Guides - Vertical dotted lines appear between braces for declaration-level things - Hovering on the line shows context	does not apply
Code Style	Naming Rules	does not apply		N/A
	Use this./me.	does not apply		N/A
	Use predefined type	does not apply		N/A
	Prefer object/collection initializer	works fine, regression tests not needed		N/A
	Prefer explicit tuple name	does not apply		N/A
	Prefer coalesce expression over null check	does not apply		N/A
	Prefer null propagation over null check	does not apply		N/A
	var preferences (C# only)	does not apply	N/A	N/A
	Prefer braces (C# only)	does not apply	N/A	N/A
	Prefer pattern matching over is/as checks (C# only)	does not apply	N/A	N/A
	Use expression body (C# only)	does not apply	N/A	N/A
	Prefer inlined variable declaration (C# only)	does not apply	N/A	N/A
	Prefer throw expression (C# only)	does not apply	N/A	N/A
	Prefer conditional delegate call (C# only)	does not apply	N/A	N/A

Project System & External Integration

(Any changes to the runtime will require much more testing in this category)
All feature descriptions and testing suggestions are merely examples. Each language feature should be carefully considered independently against each IDE feature to find interesting intersections

Category	Integration	Signoff/Notes
Projection Buffers	Razor (web) - Verify expression and block contexts - Test on projection boundaries - Emphasis on rename and formatting
	Venus - Verify expression and block contexts - Test on projection boundaries - Emphasis on rename and formatting
Designers	WPF - Event generation from designer to code - Designer consumption of new types of members - Cross language features (Go to definition, find references, rename)
	WinForms - Create a project, add some controls to the form - Verify that simple changes to InitializeComponent round-trip to the designer. - Verify that double clicking a control generates or navigates to an event handler for its default event
Project System Interactions	Linked Files (all flavors) - Regular linked files - Shared Projects - Multitargeted .NET Core Apps

Interaction with other new language features in the IDE

Verify IDE handling of the new language feature in conjunction with other new/unreleased language features

Feature	C# Signoff/Notes	VB Signoff/Notes	F# Signoff/Notes
<New Language Feature 1>
<New Language Feature 2>

New Feature Suggestions

What refactorings, fixes, code transformations, or other in-editor experiences would enhance this language feature?

Feature Name	Description
?	?
?	?

[jinujoseph]

cc @richaverma1 for info

[CyrusNajmabadi]

Closing out as not actionable.