Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MakeMethodAsync isn't aware of nullability #30325

Closed
jcouv opened this issue Oct 4, 2018 · 1 comment · Fixed by #37312
Closed

MakeMethodAsync isn't aware of nullability #30325

jcouv opened this issue Oct 4, 2018 · 1 comment · Fixed by #37312
Assignees
@jasonmalinowski
Labels
Area-IDE Bug New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
Backlog

Comments

@jcouv
Copy link
Member

jcouv commented Oct 4, 2018

image

FYI @dpoeschl
@jcouv jcouv added this to the 16.0 milestone Oct 4, 2018
@dpoeschl dpoeschl mentioned this issue Oct 4, 2018
Closed
@jinujoseph jinujoseph added the Bug label Oct 5, 2018
@jinujoseph jinujoseph modified the milestones: 16.0, 16.1 Jan 16, 2019
@jinujoseph jinujoseph modified the milestones: 16.1, Backlog Apr 24, 2019
@jasonmalinowski
Copy link
Member

This will still be blocked on the lack of an API to construct generic types with nullability.

@jasonmalinowski jasonmalinowski mentioned this issue Jul 15, 2019
Closed
@jasonmalinowski jasonmalinowski mentioned this issue Jul 17, 2019
Merged
@jasonmalinowski jasonmalinowski self-assigned this Jul 17, 2019
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Jul 30, 2019
@jasonmalinowski
Fix make method async/sync and some related code fixes
f62a891 
Fixes dotnet#30325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmalinowski jasonmalinowski

Labels
Area-IDE Bug New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix make method async/sync and some related code fixes jasonmalinowski/roslyn
3 participants
@jasonmalinowski @jinujoseph @jcouv