Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer completion for #nullable enable|disable #31171

Merged
merged 5 commits into from
Nov 15, 2018
Merged

Offer completion for #nullable enable|disable #31171

merged 5 commits into from
Nov 15, 2018

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Nov 14, 2018

This is mostly an IDE fix, but also includes a minor fix to compiler APIs.

#nullable
image

#nullable enable|disable
image

Addresses part of #31130

@jcouv jcouv added this to the 16.0.P2 milestone Nov 14, 2018
@jcouv jcouv self-assigned this Nov 14, 2018
@jcouv jcouv requested review from a team as code owners November 14, 2018 05:55
@jcouv jcouv mentioned this pull request Nov 14, 2018
Closed
3 tasks
@jcouv
Copy link
Member Author

jcouv commented Nov 14, 2018

Thanks!

@jcouv
Copy link
Member Author

jcouv commented Nov 15, 2018

@jinujoseph for preview2 approval. Thanks

@jcouv jcouv added the Blocked label Nov 15, 2018
AlekseyTs
AlekseyTs approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code under Compilers LGTM (iteration 5)

cston
cston approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@cston cston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler changes LGTM.

@jcouv jcouv merged commit 7c04f24 into dotnet:dev16.0-preview2 Nov 15, 2018
@jcouv jcouv deleted the nullable-completion branch November 15, 2018 21:14
@jcouv jcouv removed the Blocked label Nov 15, 2018
@dpoeschl dpoeschl mentioned this pull request Nov 18, 2018
Closed
@cston cston mentioned this pull request Dec 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@cston cston cston approved these changes

Assignees

@jcouv jcouv

Labels
Approved to merge Area-Compilers Area-IDE New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.0.P2
Development

Successfully merging this pull request may close these issues.
6 participants
@jcouv @sharwell @CyrusNajmabadi @AlekseyTs @cston @jinujoseph