Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need completion and indentation for #nullable #31130

Closed
3 tasks done
jcouv opened this issue Nov 13, 2018 · 1 comment
Closed
3 tasks done

Need completion and indentation for #nullable #31130

jcouv opened this issue Nov 13, 2018 · 1 comment
Labels
Area-IDE Feature Request New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
16.0.P2

Comments

@jcouv
Copy link
Member

jcouv commented Nov 13, 2018 •
edited
Loading

  • If you type #nullable I would expect completion for "nullable" (as we do for #region as depicted below) and enable/disable Offer completion for #nullable enable|disable #31171
  • After you type #nullable ... and hit return, I expect #nullable ... to indent to the margin. I expect the same would happen if you format the document. (I verified that is already the case)
  • Completion for restore after #nullable

image

image
@jcouv jcouv added this to the 16.0.P2 milestone Nov 13, 2018
This was referenced Nov 14, 2018
Merged
Merged
@jcouv jcouv modified the milestones: 16.0.P2, 16.0 Nov 18, 2018
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Dec 14, 2018
@AlekseyTs
Add support for restore and safeonly for #nullable directive.
b11b683 
Related to dotnet#31130.
@AlekseyTs AlekseyTs mentioned this issue Dec 14, 2018
Merged
@jcouv
Copy link
Member Author

jcouv commented Dec 20, 2018

restore and safeonly were added (including IDE support) in #31806
Closing

@jcouv jcouv closed this as completed Dec 20, 2018
@jcouv jcouv modified the milestones: 16.0, 16.0.P2 Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Feature Request New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.0.P2
Development

No branches or pull requests
2 participants
@sharwell @jcouv