Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name violation for private protected #36313

Closed
vsfeedback opened this issue Jun 11, 2019 · 0 comments · Fixed by #36314
Closed

Fix name violation for private protected #36313

vsfeedback opened this issue Jun 11, 2019 · 0 comments · Fixed by #36314
Assignees
Labels
Area-IDE Bug Developer Community The issue was originally reported on https://developercommunity.visualstudio.com Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@vsfeedback
Copy link

VSF_TYPE_MARKDOWNProblem 1)
Define interface named abc wit accessibility modifier private protected. There is no suggestion to fix name violation to IAbc. That's inconsistent because for private, protected, public, internal and protected internal there is suggestion for fix.

Problem 2)
Generate .editorconfig from settings. The following code is generated. I think that there should be also private_protected included.

dotnet_naming_symbols.interface.applicable_kinds = interface
dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal
dotnet_naming_symbols.interface.required_modifiers = 

This issue has been moved from https://developercommunity.visualstudio.com/content/problem/587679/fix-name-violation-for-private-protected.html
VSTS ticketId: 901099

These are the original issue comments:

Visual Studio Feedback System on 5/29/2019, 10:53 PM (12 days ago):

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

These are the original issue solutions:
(no solutions)

@sharwell sharwell self-assigned this Jun 11, 2019
sharwell added a commit to sharwell/roslyn that referenced this issue Jun 11, 2019
@sharwell sharwell added 4 - In Review A fix for the issue is submitted for review. Developer Community The issue was originally reported on https://developercommunity.visualstudio.com labels Jun 11, 2019
@jinujoseph jinujoseph added this to the 16.2 milestone Jun 11, 2019
@jinujoseph jinujoseph modified the milestones: 16.2, 16.3.P1 Jun 27, 2019
@jinujoseph jinujoseph modified the milestones: 16.3.P1, 16.3.P3, 16.4, 16.3 Aug 5, 2019
@sharwell sharwell modified the milestones: 16.3, 16.3.P3 Aug 9, 2019
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Developer Community The issue was originally reported on https://developercommunity.visualstudio.com Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants