WIP Analyzer, just bare bones diagnostic

src/Analyzers/CSharp/Analyzers/CSharpAnalyzers.projitems

@@ -18,6 +18,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)AddAccessibilityModifiers\CSharpAddAccessibilityModifiersDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)AddBraces\CSharpAddBracesDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)AddRequiredParentheses\CSharpAddRequiredPatternParenthesesDiagnosticAnalyzer.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)ConvertNameOf\CSharpConvertNameOfDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnnecessarySuppressions\CSharpRemoveUnnecessarySuppressionsDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnnecessaryParentheses\CSharpRemoveUnnecessaryPatternParenthesesDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveConfusingSuppression\CSharpRemoveConfusingSuppressionDiagnosticAnalyzer.cs" />

src/Analyzers/CSharp/Analyzers/CSharpAnalyzersResources.resx

@@ -289,4 +289,7 @@
   <data name="Suppression_operator_has_no_effect_and_can_be_misinterpreted" xml:space="preserve">
     <value>Suppression operator has no effect and can be misinterpreted</value>
   </data>
+  <data name="Convert_type_name_to_nameof" xml:space="preserve">
+    <value>Convert typeof to nameof</value>
+  </data>
 </root>

src/Analyzers/CSharp/Analyzers/ConvertNameOf/CSharpConvertNameOfDiagnosticAnalyzer.cs

@@ -0,0 +1,78 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System.Collections.Immutable;
+using System.Linq;
+using System.Linq.Expressions;
+using System.Threading;
+using Microsoft.CodeAnalysis.CodeStyle;
+using Microsoft.CodeAnalysis.CSharp.CodeStyle;
+using Microsoft.CodeAnalysis.CSharp.Extensions;
+using Microsoft.CodeAnalysis.CSharp.Syntax;
+using Microsoft.CodeAnalysis.Diagnostics;
+using Microsoft.CodeAnalysis.PooledObjects;
+using Microsoft.CodeAnalysis.Shared.Extensions;
+using Microsoft.CodeAnalysis.Text;
+
+namespace Microsoft.CodeAnalysis.CSharp.ConvertNameOf
+{
+    /// <summary>
+    /// Finds code like typeof(someType).Name and determines whether it can be changed to nameof(someType), if yes then it offers a diagnostic
+    /// </summary>
+    [DiagnosticAnalyzer(LanguageNames.CSharp)]
+    internal class CSharpConvertNameOfDiagnosticAnalyzer : AbstractBuiltInCodeStyleDiagnosticAnalyzer
+    {
+        public CSharpConvertNameOfDiagnosticAnalyzer()
+            : base(IDEDiagnosticIds.ConvertNameOfDiagnosticId,
+                   CSharpCodeStyleOptions.PreferBraces,
+                   LanguageNames.CSharp,
+                   new LocalizableResourceString(
+                       nameof(CSharpAnalyzersResources.Convert_type_name_to_nameof), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)))
+        {
+        }
+
+        protected override void InitializeWorker(AnalysisContext context)
+        {
+            context.RegisterSyntaxNodeAction(AnalyzeSyntaxAction, SyntaxKind.TypeOfExpression);
+        }
+
+        private void AnalyzeSyntaxAction(SyntaxNodeAnalysisContext syntaxContext)
+        {
+            //var options = syntaxContext.Options;
+            var syntaxTree = syntaxContext.Node.SyntaxTree;
+            //var cancellationToken = syntaxContext.CancellationToken;
+            var node = syntaxContext.Node;
+
+            // TODO: Any relevant style options?
+
+            // nameof was added in CSharp 6.0, so don't offer it for any languages after that time
+            if (((CSharpParseOptions)syntaxTree.Options).LanguageVersion < LanguageVersion.CSharp6)
+            {
+                return;
+            }
+
+            // TODO: Check for compiler errors on the typeof(someType).Name declaration
+
+            // TODO: Check that the current span is the case we're looking for
+
+            // TODO: Filter cases that don't work
+
+            // TODO: Create and report the right diagnostic
+            var location = Location.Create(syntaxTree, node.Span);
+            var additionalLocations = ImmutableArray.Create(node.GetLocation());
+
+            syntaxContext.ReportDiagnostic(DiagnosticHelper.Create(
+                     Descriptor,
+                     location,
+                     ReportDiagnostic.Hidden,
+                     additionalLocations,
+                     properties: null));
+        }
+        // TODO: Overwrite GetAnalyzerCategory
+        public override DiagnosticAnalyzerCategory GetAnalyzerCategory()
+            => DiagnosticAnalyzerCategory.SemanticSpanAnalysis;
+
+        // HELPERS GO HERE
+    }
+}

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.cs.xlf

@@ -17,6 +17,11 @@
         <target state="translated">Převést příkaz switch na výraz</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">Dekonstruovat deklaraci proměnné</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.de.xlf

@@ -17,6 +17,11 @@
         <target state="translated">Switch-Anweisung in Ausdruck konvertieren</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">Variablendeklaration dekonstruieren</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.es.xlf

@@ -17,6 +17,11 @@
         <target state="translated">Convertir una instrucción switch en expresión</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">Desconstruir la declaración de variable</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.fr.xlf

@@ -17,6 +17,11 @@
         <target state="translated">Convertir l'instruction switch en expression</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">Déconstruire la déclaration de variable</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.it.xlf

@@ -17,6 +17,11 @@
         <target state="translated">Converti l'istruzione switch in espressione</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">Decostruisci la dichiarazione di variabile</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.ja.xlf

@@ -17,6 +17,11 @@
         <target state="translated">switch ステートメントを式に変換します</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">変数の宣言を分解</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.ko.xlf

@@ -17,6 +17,11 @@
         <target state="translated">switch 문을 식으로 변환</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">변수 선언 분해</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.pl.xlf

@@ -17,6 +17,11 @@
         <target state="translated">Konwertuj instrukcję switch na wyrażenie</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">Zdekonstruuj deklarację zmiennej</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.pt-BR.xlf

@@ -17,6 +17,11 @@
         <target state="translated">Converter a instrução switch em expressão</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">Desconstruir declaração de variável</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.ru.xlf

@@ -17,6 +17,11 @@
         <target state="translated">Преобразовать оператор switch в выражение</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">Деконструировать объявление переменной</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.tr.xlf

@@ -17,6 +17,11 @@
         <target state="translated">Switch deyimini ifadeye dönüştür</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">Değişken bildirimini ayrıştır</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.zh-Hans.xlf

@@ -17,6 +17,11 @@
         <target state="translated">将 switch 语句转换为表达式</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">析构变量声明</target>

src/Analyzers/CSharp/Analyzers/xlf/CSharpAnalyzersResources.zh-Hant.xlf

@@ -17,6 +17,11 @@
         <target state="translated">將 switch 陳述式轉換為運算式</target>
         <note />
       </trans-unit>
+      <trans-unit id="Convert_type_name_to_nameof">
+        <source>Convert typeof to nameof</source>
+        <target state="new">Convert typeof to nameof</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Deconstruct_variable_declaration">
         <source>Deconstruct variable declaration</source>
         <target state="translated">解構變數宣告</target>