No-op SymbolSearchUpdateEngine on non-Windows OS #45764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| => Task.FromResult(ImmutableArray<ReferenceAssemblyWithTypeResult>.Empty); | ||
|
|
||
| public Task UpdateContinuouslyAsync(string sourceName, string localSettingsDirectory) | ||
| => Task.CompletedTask; | ||
| } |
There was a problem hiding this comment.
Hmm, we have 3 private types defined in this file, NoOpUpdateEngine, RemoteUpdateEngine and CallbackObject, their implementation are simple only used within this file. I'd prefer to keep them here, unless separate files is absolutely required by our code style.
CyrusNajmabadi
approved these changes
Jul 7, 2020
jasonmalinowski
approved these changes
Jul 7, 2020
src/EditorFeatures/Core/SymbolSearch/SymbolSearchUpdateEngineFactory.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core/SymbolSearch/SymbolSearchUpdateEngineFactory.cs
Outdated
Show resolved
Hide resolved
…actory.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>
…actory.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>
genlu
commented
Jul 7, 2020
src/EditorFeatures/Core/SymbolSearch/SymbolSearchUpdateEngineFactory.cs
Outdated
Show resolved
Hide resolved
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To guard against potential misuse, since it only works on Windows.
@sharwell