Allow static members in interfaces to treat type parameters as invariant #46141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@333fred, @RikkiGibson, @cston, @jcouv, @dotnet/roslyn-compiler Please review. |
1 similar comment
|
@333fred, @RikkiGibson, @cston, @jcouv, @dotnet/roslyn-compiler Please review. |
RikkiGibson
approved these changes
Jul 21, 2020
| @@ -1866,6 +1866,7 @@ internal enum ErrorCode | |||
| ERR_StaticAPIInRecord = 8877, | |||
| ERR_CopyConstructorWrongAccessibility = 8878, | |||
| ERR_NonPrivateAPIInRecord = 8879, | |||
| ERR_UnexpectedVarianceStaticMemmber = 8880, | |||
There was a problem hiding this comment.
nit: Memmber -> Member #Resolved
|
IDE side is fine :) |
333fred
reviewed
Jul 21, 2020
| parseOptions: TestOptions.Regular8, | ||
| targetFramework: TargetFramework.NetStandardLatest); | ||
| compilation1.VerifyDiagnostics( | ||
| // (13,18): error CS8880: Invalid variance: The type parameter 'T1' must be contravariantly valid on 'I2<T1, T2>.M1(T1)' unless language version 'preview' or greater is used. 'T1' is covariant. |
There was a problem hiding this comment.
must be contravariantly valid [](start = 84, length = 29)
I think a better wording would be "cannot be used contra/co/invariantly". #WontFix
There was a problem hiding this comment.
I think a better wording would be "cannot be used contra/co/invariantly".
I am sharing the wording with existing message. Changing the wording is outside of the scope of this PR
In reply to: 458353056 [](ancestors = 458353056)
333fred
approved these changes
Jul 21, 2020
cston
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/csharplang#3275
https://github.com/dotnet/csharplang/blob/master/meetings/2020/LDM-2020-06-24.md#interface-static-member-variance
https://github.com/dotnet/csharplang/blob/master/proposals/variance-safety-for-static-interface-members.md