Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename types to not collide with the much more relevant Workspace equivalents #46227

Merged
1 commit merged into from
Jul 22, 2020
Merged

Rename types to not collide with the much more relevant Workspace equivalents #46227

1 commit merged into from
Jul 22, 2020

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner July 22, 2020 20:11
genlu
genlu approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

sharwell
sharwell approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting second review from @jasonmalinowski

ghost
ghost approved these changes Jul 22, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 127aa50 into dotnet:master Jul 22, 2020
@ghost ghost added this to the Next milestone Jul 22, 2020
@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the renameTypes branch April 11, 2021 18:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genlu genlu genlu approved these changes

@sharwell sharwell sharwell approved these changes

@jasonmalinowski jasonmalinowski Awaiting requested review from jasonmalinowski

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
16.8.P2
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @genlu @sharwell @RikkiGibson