Fix race condition in SolutionChecksumUpdater work queue #46346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
updaterservice-test
branch
from
dc30732
to
ca372f4
Compare
src/VisualStudio/Core/Def/Implementation/Remote/SolutionChecksumUpdater.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/Remote/SolutionChecksumUpdater.cs
Show resolved
Hide resolved
| { | ||
| Contract.ThrowIfFalse(_currentToken is null); | ||
| _currentToken = currentToken; | ||
| } |
There was a problem hiding this comment.
tbh, i've stared at thsi a bunch, and i have no feeling on what's happening here or why the new code is more correct. Can you write a non-brief explanation of what this class is trying to accomplish, how tehse two fields play into it, and why the new approach is 'correct'?
There was a problem hiding this comment.
I don't understand this class well enough to detail its intended functionality. An explanation of the race condition is here:
The sequencing is complex enough that it required a handwritten derivation before I was able to construct a deterministic failure using 4 counters and 6 instances of ManualResetEventSlim.
sharwell
force-pushed
the
updaterservice-test
branch
from
ca372f4
to
bb69323
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46255