Don't offer Use Explicit Type for target typed new #46469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Jul 31, 2020
| @@ -286,6 +286,16 @@ private static bool IsSafeToSwitchToVarWithoutNeedingSpeculation(DeclarationExpr | |||
| return false; | |||
| } | |||
|
|
|||
| // var cannot be used with target typed new | |||
| #if CODE_STYLE | |||
There was a problem hiding this comment.
I have no idea if this is the right thing to do with CODE_STYLE, or really what CODE_STYLE is or means, but its Friday afternoon for me so thought I'd just put up a PR and see what happens 😄
There was a problem hiding this comment.
Looks good to me. @sharwell for another pair of eyes.
There was a problem hiding this comment.
There is no need for the condition here. Just use SyntaxKindEx on both paths.
mavasani
approved these changes
Jul 31, 2020
jmarolf
approved these changes
Jul 31, 2020
CyrusNajmabadi
approved these changes
Jul 31, 2020
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this today while doing something else. Couldn't find a bug for it, should I log one?