Fix crash in SpillSequenceSpiller #47428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will probably enable nullable in this file in the near future, but we want this to be ready to backport to 16.7, so won't do it in this PR. |
RikkiGibson
force-pushed
the
fix-47191
branch
from
88bffa5
to
bb536d5
Compare
jaredpar
reviewed
Sep 3, 2020
| } | ||
|
|
||
| [Fact, WorkItem(47191, "https://github.com/dotnet/roslyn/issues/47191")] | ||
| public void AssignInstanceStructField() |
There was a problem hiding this comment.
Let's add similar tests for VB. If we regressed this in C# then seems a fair bet we could accidentally regress it in VB as well.
| @@ -6319,5 +6319,66 @@ .maxstack 3 | |||
| IL_009e: ret | |||
| }"); | |||
| } | |||
|
|
|||
| [Fact, WorkItem(47191, "https://github.com/dotnet/roslyn/issues/47191")] | |||
| public void AssignStaticStructField() | |||
There was a problem hiding this comment.
Please add a test where we grab a static field w/o a qualifier by means of using static. Basically not just a direct static field access on the current type.
jaredpar
approved these changes
Sep 3, 2020
cston
approved these changes
Sep 3, 2020
|
Looks like https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1193818 was approved for Ask Mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47191
The bug was that we assume that a field access has a receiver even if the field is static. I can't see any need to spill the receiver of a static field, so I made the compiler skip that step in that scenario.
I found that referencing the static field via a type name also prevents the crash in master, e.g. using
C.s1.fieldin the below test instead ofs1.field. I was surprised that the ReceiverOpt is present using the former but it is null with the latter."Hide whitespace changes" is recommended when reviewing.