Do not export IDE0079 (remove unnecessary suppressions) analyzer in C… #47944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmarolf Will the CodeStyle assemblies from master eventually flow into .NET5 SDK? This is a fix to the CodeStyle package itself. |
Youssef1313
reviewed
Sep 22, 2020
...eUnnecessarySuppressions/VisualBasicRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.vb
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Sep 22, 2020
...eUnnecessarySuppressions/VisualBasicRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.vb
Outdated
Show resolved
Hide resolved
|
@mavasani I can update the sdk to include this change. Does this need to do into VS 16.8? If so I believe it will need to target a different branch |
|
@jmarolf I thought master is still targeting 16.8 P4. @vatsalyaagrawal @jinujoseph to confirm. |
jmarolf
approved these changes
Sep 22, 2020
|
Thanks @jmarolf! |
…odeStyle layer Fixes dotnet#47942 This is a special IDE-only analyzer that should not be exported in the CodeStyle NuGet package. We still want to retain the code in the shared analyzer layer to allow different analyzer hosts to be able to explicitly instantiate it and enforce it on command line from the CodeStyle package.
mavasani
force-pushed
the
Fix_IDE0079
branch
from
ef623dc
to
315c5bf
Compare
|
Hello @mavasani! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…odeStyle layer
Fixes #47942
This is a special IDE-only analyzer that should not be exported in the CodeStyle NuGet package. We still want to retain the code in the shared analyzer layer to allow different analyzer hosts to be able to explicitly instantiate it and enforce it on command line from the CodeStyle package.