Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't offer generate parameter/field/property for top-level programs #48173

Merged
merged 9 commits into from
Oct 1, 2020
Merged

Don't offer generate parameter/field/property for top-level programs #48173

merged 9 commits into from
Oct 1, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 29, 2020 •
edited
Loading

Fixes #48171
Fixes #48172

@Youssef1313 Youssef1313 requested a review from a team as a code owner September 29, 2020 22:35
@Youssef1313 @CyrusNajmabadi
Apply suggestions from code review
c7dba08 
Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Sep 30, 2020
This was referenced Sep 30, 2020
Closed
Closed
@Youssef1313
Change IsImplicitClass to IsImplicitlyDeclared
bfc3a12 
Checking if this will resolve the issue for C#-script.
@Youssef1313 @CyrusNajmabadi
Pattern matching
bd54730 
Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
This was referenced Sep 30, 2020
Closed
Closed
Closed
Closed
@Youssef1313 Youssef1313 changed the title Don't offer generate parameter for implicitly declared methods Don't offer generate parameter/field/property for top-level programs Oct 1, 2020
Youssef1313
Youssef1313 commented Oct 1, 2020
View reviewed changes
src/EditorFeatures/CSharpTest/GenerateVariable/GenerateVariableTests.cs
[Fact, Trait(Traits.Feature, Traits.Features.CodeActionsGenerateVariable)]
public async Task TestMissingOfferParameterInTopLevel()
{
await TestMissingAsync("[|Console|].WriteLine();", new TestParameters(Options.Regular));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is for Regular C# only.
C#-script have a different behavior which is already tested in other tests.

@Youssef1313
Copy link
Member Author

@CyrusNajmabadi If the tests passed and this is ready, please squash when merging.

@Youssef1313
Copy link
Member Author

@CyrusNajmabadi Build is green here.

@CyrusNajmabadi CyrusNajmabadi merged commit afd1030 into dotnet:master Oct 1, 2020
@ghost ghost added this to the Next milestone Oct 1, 2020
@CyrusNajmabadi
Copy link
Member

Thanks!

@Youssef1313 Youssef1313 deleted the patch-42 branch October 1, 2020 21:14
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.9.P1
4 participants
@Youssef1313 @CyrusNajmabadi @jinujoseph @Cosifne