Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new parser/lexer to the StackTraceAnalyzer #57598
Add new parser/lexer to the StackTraceAnalyzer #57598
Changes from 15 commits
c909bd2
e3aa08c
0836018
6ccfd3e
68dff0d
1c715cd
42bca8e
4728084
a5f89c1
08dc08e
2f3597c
649db70
c9f447f
3e96c8b
df34218
5899745
f82b9e6
501bbc9
05a8f09
79ac4f6
5b6a85c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the candidateProjects local seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just keeps us from getting the compilation twice and searching on a project that we already searched. Could do without... 🤷 the compilation would already be computed so theoretically the expensive part is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already checked source above. so really we just want to check metdata. so we should have a hashset tracking which PE references we looked at. we should then walk each project and walk the PE refs of each, seeing if it's the first time we're seeing it. if so, we should check our metadata-index for that pe-ref to see if it's a hit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should do this in a follow up PR, it seems complex enough to warrant it's own commit and some feedback on the correct way to do it.