Offer 'field' when within a property accessor. #74956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test Add test
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Aug 30, 2024
| @@ -7,222 +7,419 @@ | |||
| using Microsoft.CodeAnalysis.Test.Utilities; | |||
| using Xunit; | |||
|
|
|||
| namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Recommendations | |||
| namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Recommendations; | |||
There was a problem hiding this comment.
view with whitespace off.
dibarbet
approved these changes
Aug 30, 2024
sharwell
reviewed
Aug 30, 2024
| // version check here. We do not want to interfere with users trying to use/learn this feature. The user will | ||
| // get a clear message if they're not on the right lang version telling them about the issue, and offering to | ||
| // upgrade their project if they way. | ||
| if (context.IsAnyExpressionContext || context.IsStatementContext) |
There was a problem hiding this comment.
💭 Is there a case where IsAnyExpressionContext is false but IsStatementContext is true?
| => context.IsMemberAttributeContext(s_validTypeDeclarations, cancellationToken); | ||
| private static bool IsInPropertyAccessor(SyntaxToken targetToken) | ||
| { | ||
| for (var node = targetToken.Parent; node != null; node = node.Parent) |
There was a problem hiding this comment.
❔ Does this intentionally walk out of local functions? Even if so, it seems like static local functions should be skipped.
There was a problem hiding this comment.
yes. it intentionally walks out of local functions.
There was a problem hiding this comment.
Even if so, it seems like static local functions should be skipped.
field is allowed ina static local/lambda if hte containing property is also static. We could consdier adding the logic to check for that. but i'm in the not-caring poitn currently.
CyrusNajmabadi
merged commit 08b50e8
into
dotnet:features/field-keyword
22 of 25 checks passed
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.