Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some emit tests from Emit2 to Emit3 to avoid hitting UserString heap limit #75091

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Move some emit tests from Emit2 to Emit3 to avoid hitting UserString heap limit #75091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8afb518
Move some emit tests from Emit2 to Emit3 to avoid hitting UserString …
tmat Sep 12, 2024
e596326
Fixes
tmat Sep 12, 2024
ffa25f9
Remove unused using
tmat Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions src/Compilers/CSharp/Test/Emit2/Emit/UnmanagedTypeModifierTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,13 +576,13 @@ public class Child : Parent
Assert.True(parentTypeParameter.HasValueTypeConstraint);
Assert.True(parentTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);

var childTypeParameter = module.ContainingAssembly.GetTypeByMetadataName("Child").GetMethod("M").TypeParameters.Single();
Assert.True(childTypeParameter.HasValueTypeConstraint);
Assert.True(childTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand Down Expand Up @@ -611,7 +611,7 @@ public class Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

var child = CompileAndVerify(@"
Expand All @@ -624,7 +624,7 @@ public class Child : Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand Down Expand Up @@ -657,13 +657,13 @@ public class Child : Parent
Assert.True(parentTypeParameter.HasValueTypeConstraint);
Assert.True(parentTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);

var childTypeParameter = module.ContainingAssembly.GetTypeByMetadataName("Child").GetMethod("M").TypeParameters.Single();
Assert.True(childTypeParameter.HasValueTypeConstraint);
Assert.True(childTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand All @@ -689,7 +689,7 @@ public abstract class Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

var child = CompileAndVerify(@"
Expand All @@ -702,7 +702,7 @@ public class Child : Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand Down Expand Up @@ -732,13 +732,13 @@ public class Child : Parent
Assert.True(parentTypeParameter.HasValueTypeConstraint);
Assert.True(parentTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);

var childTypeParameter = module.ContainingAssembly.GetTypeByMetadataName("Child").GetMethod("M").TypeParameters.Single();
Assert.True(childTypeParameter.HasValueTypeConstraint);
Assert.True(childTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand All @@ -764,7 +764,7 @@ public interface Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

var child = CompileAndVerify(@"
Expand All @@ -777,7 +777,7 @@ public class Child : Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand Down Expand Up @@ -807,13 +807,13 @@ public class Child : Parent
Assert.True(parentTypeParameter.HasValueTypeConstraint);
Assert.True(parentTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);

var childTypeParameter = module.ContainingAssembly.GetTypeByMetadataName("Child").GetMethod("M").TypeParameters.Single();
Assert.True(childTypeParameter.HasValueTypeConstraint);
Assert.True(childTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand All @@ -839,7 +839,7 @@ public interface Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

var child = CompileAndVerify(@"
Expand All @@ -852,7 +852,7 @@ public class Child : Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand Down Expand Up @@ -882,13 +882,13 @@ public class Child : Parent
Assert.True(parentTypeParameter.HasValueTypeConstraint);
Assert.True(parentTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, parentTypeParameter, module.ContainingAssembly.Name);

var childTypeParameter = module.ContainingAssembly.GetTypeByMetadataName("Child").GetMethod("Parent.M").TypeParameters.Single();
Assert.True(childTypeParameter.HasValueTypeConstraint);
Assert.True(childTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, childTypeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand All @@ -915,7 +915,7 @@ public interface Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

var child = CompileAndVerify(@"
Expand All @@ -928,7 +928,7 @@ public class Child : Parent
Assert.True(typeParameter.HasValueTypeConstraint);
Assert.True(typeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand Down Expand Up @@ -974,13 +974,13 @@ public static void Main()
Assert.True(delegateTypeParameter.HasValueTypeConstraint);
Assert.True(delegateTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, delegateTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, delegateTypeParameter, module.ContainingAssembly.Name);

var lambdaTypeParameter = module.ContainingAssembly.GetTypeByMetadataName("Program").GetTypeMember("<>c__DisplayClass0_0").TypeParameters.Single();
Assert.True(lambdaTypeParameter.HasValueTypeConstraint);
Assert.True(lambdaTypeParameter.HasUnmanagedTypeConstraint);

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, lambdaTypeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, lambdaTypeParameter, module.ContainingAssembly.Name);
});
}

Expand All @@ -1002,7 +1002,7 @@ public static void Print<T>(D<T> lambda) where T : unmanaged
Assert.True(typeParameter.HasUnmanagedTypeConstraint);
Assert.False(typeParameter.HasConstructorConstraint); // .ctor is an artifact of emit, we will ignore it on importing.

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});

CompileAndVerify(@"
Expand All @@ -1028,7 +1028,7 @@ public static void Main()
Assert.True(typeParameter.HasUnmanagedTypeConstraint);
Assert.False(typeParameter.HasConstructorConstraint); // .ctor is an artifact of emit, we will ignore it on importing.

AttributeTests_IsUnmanaged.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
AttributeValidation.AssertReferencedIsUnmanagedAttribute(Accessibility.Internal, typeParameter, module.ContainingAssembly.Name);
});
}

Expand Down
0 ...p/Test/Emit2/Attributes/AttributeTests.cs → ...p/Test/Emit3/Attributes/AttributeTests.cs
View file
Open in desktop
File renamed without changes.
0 ...it2/Attributes/AttributeTests_Assembly.cs → ...it3/Attributes/AttributeTests_Assembly.cs
View file
Open in desktop
File renamed without changes.
0 ...es/AttributeTests_CallerInfoAttributes.cs → ...es/AttributeTests_CallerInfoAttributes.cs
View file
Open in desktop
File renamed without changes.
0 .../Attributes/AttributeTests_Conditional.cs → .../Attributes/AttributeTests_Conditional.cs
View file
Open in desktop
File renamed without changes.
0 ...mit2/Attributes/AttributeTests_Dynamic.cs → ...mit3/Attributes/AttributeTests_Dynamic.cs
View file
Open in desktop
File renamed without changes.
0 ...it2/Attributes/AttributeTests_Embedded.cs → ...it3/Attributes/AttributeTests_Embedded.cs
View file
Open in desktop
File renamed without changes.
0 ...Attributes/AttributeTests_Experimental.cs → ...Attributes/AttributeTests_Experimental.cs
View file
Open in desktop
File renamed without changes.
0 .../Attributes/AttributeTests_IsByRefLike.cs → .../Attributes/AttributeTests_IsByRefLike.cs
View file
Open in desktop
File renamed without changes.
Loading
Loading