Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null dereference in GetAssemblyReferenceAlias #75094

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Fix null dereference in GetAssemblyReferenceAlias #75094

merged 4 commits into from
Sep 24, 2024

Conversation

AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Sep 12, 2024 •
edited
Loading

Fixes #74872.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 12, 2024
@AlekseyTs AlekseyTs changed the title Issue 74872 Fix null dereference in GetAssemblyReferenceAlias Sep 18, 2024
@AlekseyTs AlekseyTs marked this pull request as ready for review September 18, 2024 22:12
@AlekseyTs AlekseyTs requested a review from a team as a code owner September 18, 2024 22:12
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For the second review

3 similar comments
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For the second review

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For the second review

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For the second review

@AlekseyTs AlekseyTs requested a review from a team September 24, 2024 15:42
@jcouv jcouv self-assigned this Sep 24, 2024
jcouv
jcouv approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 4)

@AlekseyTs AlekseyTs merged commit 03f4130 into dotnet:main Sep 24, 2024
24 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 24, 2024
@dotnet-bot dotnet-bot mentioned this pull request Sep 26, 2024
Closed
@akhera99 akhera99 modified the milestones: Next, 17.12 P3 Sep 26, 2024
This was referenced Sep 27, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P3
Development

Successfully merging this pull request may close these issues.

Microsoft.Cci.PdbWriter.GetAssemblyReferenceAlias throws Null Reference exception
4 participants
@AlekseyTs @333fred @jcouv @akhera99