Skip to content

Commit

Permalink
Disable distributed transaction tests on ARM (#74573)
Browse files Browse the repository at this point in the history
To unblock CI build failures, works around #74170

Co-authored-by: Shay Rojansky <roji@roji.org>
  • Loading branch information
github-actions[bot] and roji committed Aug 25, 2022
1 parent 71b27a5 commit 0969048
Showing 1 changed file with 32 additions and 16 deletions.
48 changes: 32 additions & 16 deletions src/libraries/System.Transactions.Local/tests/OleTxTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@ public OleTxTests(OleTxFixture fixture)
[InlineData(Phase1Vote.ForceRollback, Phase1Vote.Prepared, EnlistmentOutcome.Aborted, EnlistmentOutcome.Aborted, TransactionStatus.Aborted)]
public void Two_durable_enlistments_commit(Phase1Vote vote1, Phase1Vote vote2, EnlistmentOutcome expectedOutcome1, EnlistmentOutcome expectedOutcome2, TransactionStatus expectedTxStatus)
{
if (!Environment.Is64BitProcess)
if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
{
return; // Temporarily skip on 32-bit where we have an issue
// Temporarily skip on 32-bit where we have an issue
// ARM64 issue: https://github.com/dotnet/runtime/issues/74170
return;
}

using var tx = new CommittableTransaction();
Expand Down Expand Up @@ -61,9 +63,11 @@ public void Two_durable_enlistments_commit(Phase1Vote vote1, Phase1Vote vote2, E
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
public void Two_durable_enlistments_rollback()
{
if (!Environment.Is64BitProcess)
if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
{
return; // Temporarily skip on 32-bit where we have an issue
// Temporarily skip on 32-bit where we have an issue
// ARM64 issue: https://github.com/dotnet/runtime/issues/74170
return;
}

using var tx = new CommittableTransaction();
Expand All @@ -89,9 +93,11 @@ public void Two_durable_enlistments_rollback()
[InlineData(2)]
public void Volatile_and_durable_enlistments(int volatileCount)
{
if (!Environment.Is64BitProcess)
if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
{
return; // Temporarily skip on 32-bit where we have an issue
// Temporarily skip on 32-bit where we have an issue
// ARM64 issue: https://github.com/dotnet/runtime/issues/74170
return;
}

using var tx = new CommittableTransaction();
Expand Down Expand Up @@ -122,9 +128,11 @@ public void Volatile_and_durable_enlistments(int volatileCount)
[ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))]
public void Promotion()
{
if (!Environment.Is64BitProcess)
if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
{
return; // Temporarily skip on 32-bit where we have an issue
// Temporarily skip on 32-bit where we have an issue
// ARM64 issue: https://github.com/dotnet/runtime/issues/74170
return;
}

// This simulates the full promotable flow, as implemented for SQL Server.
Expand Down Expand Up @@ -301,9 +309,11 @@ public void SinglePhaseCommit(SinglePhaseEnlistment singlePhaseEnlistment)
[ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))]
public void Recovery()
{
if (!Environment.Is64BitProcess)
if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
{
return; // Temporarily skip on 32-bit where we have an issue
// Temporarily skip on 32-bit where we have an issue
// ARM64 issue: https://github.com/dotnet/runtime/issues/74170
return;
}

// We are going to spin up an external process to also enlist in the transaction, and then to crash when it
Expand Down Expand Up @@ -413,9 +423,11 @@ public void InDoubt(Enlistment enlistment)
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
public void TransmitterPropagationToken()
{
if (!Environment.Is64BitProcess)
if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
{
return; // Temporarily skip on 32-bit where we have an issue
// Temporarily skip on 32-bit where we have an issue
// ARM64 issue: https://github.com/dotnet/runtime/issues/74170
return;
}

using var tx = new CommittableTransaction();
Expand All @@ -434,9 +446,11 @@ public void TransmitterPropagationToken()
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
public void GetExportCookie()
{
if (!Environment.Is64BitProcess)
if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
{
return; // Temporarily skip on 32-bit where we have an issue
// Temporarily skip on 32-bit where we have an issue
// ARM64 issue: https://github.com/dotnet/runtime/issues/74170
return;
}

using var tx = new CommittableTransaction();
Expand Down Expand Up @@ -483,9 +497,11 @@ public class OleTxFixture
{
public OleTxFixture()
{
if (!Environment.Is64BitProcess)
if (!Environment.Is64BitProcess || PlatformDetection.IsArm64Process)
{
return; // Temporarily skip on 32-bit where we have an issue
// Temporarily skip on 32-bit where we have an issue
// ARM64 issue: https://github.com/dotnet/runtime/issues/74170
return;
}

// In CI, we sometimes get XACT_E_TMNOTAVAILABLE on the very first attempt to connect to MSDTC;
Expand Down

0 comments on commit 0969048

Please sign in to comment.