Skip to content

Commit

Permalink
Disable several GenericMath tests on iOS/tvOS (#61922)
Browse files Browse the repository at this point in the history
The tests were failing on iOS/tvOS device runs.  #61920 was created to track them.

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
  • Loading branch information
steveisok and Steve Pfister committed Nov 23, 2021
1 parent 25ebdcf commit 0f40573
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,7 @@ public static void CreateSaturatingFromCharTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void CreateSaturatingFromInt16Test()
{
Assert.Equal((nint)0x00000000, NumberHelper<nint>.CreateSaturating<short>(0x0000));
Expand Down Expand Up @@ -846,6 +847,7 @@ public static void CreateSaturatingFromIntPtrTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void CreateSaturatingFromSByteTest()
{
Assert.Equal((nint)0x00000000, NumberHelper<nint>.CreateSaturating<sbyte>(0x00));
Expand Down Expand Up @@ -949,6 +951,7 @@ public static void CreateTruncatingFromCharTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void CreateTruncatingFromInt16Test()
{
if (Environment.Is64BitProcess)
Expand Down Expand Up @@ -1022,6 +1025,7 @@ public static void CreateTruncatingFromIntPtrTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void CreateTruncatingFromSByteTest()
{
if (Environment.Is64BitProcess)
Expand Down Expand Up @@ -1231,6 +1235,7 @@ public static void TryCreateFromCharTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void TryCreateFromInt16Test()
{
nint result;
Expand Down Expand Up @@ -1355,6 +1360,7 @@ public static void TryCreateFromIntPtrTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void TryCreateFromSByteTest()
{
nint result;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/tests.proj
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@

<ItemGroup Condition="'$(TargetOS)' == 'iOSSimulator' and '$(TargetArchitecture)' == 'arm64' and '$(RunDisablediOSTests)' != 'true'">
<!-- Functional tests on arm64 simulator have problems with return codes from mlaunch -->
<ProjectExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\$(TargetOS)\Simulator\**\*.Test.csproj" />
<ProjectExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\iOS\Simulator\**\*.Test.csproj" />
</ItemGroup>

<!-- Excluding all tests for devices until building on helix works properly -->
Expand Down

0 comments on commit 0f40573

Please sign in to comment.