fix NodeJS fetch detection (#89393)

dotnet · Jul 25, 2023 · 1bfd46d · 1bfd46d
1 parent 6679062
commit 1bfd46d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs
@@ -584,7 +584,7 @@ public HttpMetricsTest_Http11(ITestOutputHelper output) : base(output)
         {
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNodeJS))]
         public async Task RequestDuration_EnrichmentHandler_ContentLengthError_Recorded()
         {
             await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

diff --git a/src/mono/wasm/runtime/loader/polyfills.ts b/src/mono/wasm/runtime/loader/polyfills.ts
@@ -81,9 +81,10 @@ export async function detect_features_and_polyfill(module: DotnetModuleInternal)
     }
 }
 
-const hasFetch = typeof (globalThis.fetch) === "function";
 export async function fetch_like(url: string, init?: RequestInit): Promise<Response> {
     try {
+        // this need to be detected only after we import node modules in onConfigLoaded
+        const hasFetch = typeof (globalThis.fetch) === "function";
         if (ENVIRONMENT_IS_NODE) {
             const isFileUrl = url.startsWith("file://");
             if (!isFileUrl && hasFetch) {