Fix TransactionInterop.GetDtcTransaction() (#74776)

Incorrect COM interop definition Fixes #74745
dotnet · Aug 30, 2022 · 28aa861 · 28aa861
1 parent 704c739
commit 28aa861
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/...tem.Transactions.Local/src/System/Transactions/DtcProxyShim/DtcInterfaces/ITransaction.cs b/...tem.Transactions.Local/src/System/Transactions/DtcProxyShim/DtcInterfaces/ITransaction.cs
@@ -11,9 +11,15 @@ namespace System.Transactions.DtcProxyShim.DtcInterfaces;
 [ComImport, Guid(Guids.IID_ITransaction), InterfaceType(ComInterfaceType.InterfaceIsIUnknown)]
 internal interface ITransaction
 {
-    void Commit([MarshalAs(UnmanagedType.Bool)] bool fRetainingt, [MarshalAs(UnmanagedType.U4)] OletxXacttc grfTC, uint grfRM);
+    void Commit(
+        [MarshalAs(UnmanagedType.Bool)] bool fRetainingt,
+        [MarshalAs(UnmanagedType.U4)] OletxXacttc grfTC,
+        uint grfRM);
 
-    void Abort(IntPtr reason, [MarshalAs(UnmanagedType.Bool)] bool retaining, [MarshalAs(UnmanagedType.Bool)] bool async);
+    void Abort(
+        IntPtr reason,
+        [MarshalAs(UnmanagedType.Bool)] bool retaining,
+        [MarshalAs(UnmanagedType.Bool)] bool async);
 
     void GetTransactionInfo(out OletxXactTransInfo xactInfo);
 }
diff --git a/...ansactions.Local/src/System/Transactions/DtcProxyShim/DtcInterfaces/ITransactionCloner.cs b/...ansactions.Local/src/System/Transactions/DtcProxyShim/DtcInterfaces/ITransactionCloner.cs
@@ -10,5 +10,17 @@ namespace System.Transactions.DtcProxyShim.DtcInterfaces;
 [ComImport, Guid("02656950-2152-11d0-944C-00A0C905416E"), InterfaceType(ComInterfaceType.InterfaceIsIUnknown)]
 internal interface ITransactionCloner
 {
+    void Commit(
+        [MarshalAs(UnmanagedType.Bool)] bool fRetainingt,
+        [MarshalAs(UnmanagedType.U4)] OletxXacttc grfTC,
+        uint grfRM);
+
+    void Abort(
+        IntPtr reason,
+        [MarshalAs(UnmanagedType.Bool)] bool retaining,
+        [MarshalAs(UnmanagedType.Bool)] bool async);
+
+    void GetTransactionInfo(out OletxXactTransInfo xactInfo);
+
     void CloneWithCommitDisabled([MarshalAs(UnmanagedType.Interface)] out ITransaction ppITransaction);
 }
diff --git a/src/libraries/System.Transactions.Local/tests/OleTxTests.cs b/src/libraries/System.Transactions.Local/tests/OleTxTests.cs
@@ -433,8 +433,8 @@ public void GetExportCookie()
             Assert.Equal(tx.TransactionInformation.DistributedIdentifier, tx2.TransactionInformation.DistributedIdentifier);
         });
 
-    // Test currently skipped, #74745
-    private void GetDtcTransaction()
+    [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
+    public void GetDtcTransaction()
         => Test(() =>
         {
             using var tx = new CommittableTransaction();