-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clean the OpenSSL error queue more consistently
This change started with the intent of changing the error code / message from an OpenSSL-based exception from the most recent error in the queue to the oldest error that was produced after the operation started. This was motivated mostly by EVP_PKEY2PKCS8(pkey) incorrectly indicating a malloc failure after producing the original/correct error that pkey did not have a private key portion. Having fully developed the experiment, data showed that while for EVP_PKEY2PKCS8 the first (of two) errors was the better one, for everything else with more than one error reported, the last error was at least as good as, and often better, than the first error. With that data in hand, this change now represents more consistently cleaning the error queue, and reducing the overhead in producing the exception objects. Co-authored-by: Kevin Jones <vcsjones@github.com>
- Loading branch information
Showing
27 changed files
with
456 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.