Skip to content

Commit

Permalink
Revert adding asserts in tests
Browse files Browse the repository at this point in the history
Since the tests run across different printer hardware they can't take a
dependency on the default printer settings. Revert adding asserts in
these cases so the tests still verify that the properties don't throw.
  • Loading branch information
MattKotsenas committed Jul 17, 2020
1 parent fb2055e commit 7b3cb5e
Showing 1 changed file with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,13 @@ public void CanDuplex_ReturnsExpected()
{
var printerSettings = new PrinterSettings();
bool canDuplex = printerSettings.CanDuplex;
Assert.True(canDuplex);
}

[ConditionalFact(Helpers.IsDrawingSupported)]
public void Copies_Default_ReturnsExpected()
{
var printerSettings = new PrinterSettings();
int copies = printerSettings.Copies;
Assert.Equal(1, copies);
}

[ConditionalTheory(Helpers.IsDrawingSupported)]
Expand Down Expand Up @@ -87,7 +85,6 @@ public void Collate_Default_ReturnsExpected()
{
var printerSettings = new PrinterSettings();
bool collate = printerSettings.Collate;
Assert.True(collate);
}

[ConditionalFact(Helpers.IsDrawingSupported)]
Expand Down Expand Up @@ -400,7 +397,6 @@ public void IsDirectPrintingSupported_ImageFormatSupported_ReturnsExpected(Image
{
var printerSettings = new PrinterSettings();
bool supported = printerSettings.IsDirectPrintingSupported(imageFormat);
Assert.True(supported);
}

public static IEnumerable<object[]> IsDirectPrintingSupported_ImageFormatNotSupported_TestData()
Expand Down

0 comments on commit 7b3cb5e

Please sign in to comment.