Remove illink test workaround for removed declaring type (#89529)

dotnet · Jul 27, 2023 · 89030ce · 89030ce
1 parent b9c6d68
commit 89030ce
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/MethodReturnParameterDataFlow.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/MethodReturnParameterDataFlow.cs
@@ -36,6 +36,7 @@ public static void Main ()
 			instance.ReturnWithRequirementsAlwaysThrows ();
 
 			UnsupportedReturnType ();
+			UnsupportedReturnTypeAndParameter (null);
 		}
 
 		static Type NoRequirements ()

diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/PropertyDataFlow.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/PropertyDataFlow.cs
@@ -32,6 +32,7 @@ public static void Main ()
 			instance.PropertyPublicParameterlessConstructorWithExplicitAccessors = null;
 			instance.PropertyPublicConstructorsWithExplicitAccessors = null;
 			instance.PropertyNonPublicConstructorsWithExplicitAccessors = null;
+			_ = PropertyWithUnsupportedType;
 
 			TestAutomaticPropagation ();
 

diff --git a/src/tools/illink/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs b/src/tools/illink/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs
@@ -974,16 +974,7 @@ bool LogMessageHasSameOriginMember (MessageContainer mc, ICustomAttributeProvide
 
 				var actualMember = origin?.Provider as IMemberDefinition;
 				var expectedOriginMember = expectedOriginProvider as IMemberDefinition;
-				if (actualMember?.FullName == expectedOriginMember.FullName)
-					return true;
-
-				// Compensate for cases where for some reason the OM doesn't preserve the declaring types
-				// on certain things after trimming.
-				if (actualMember != null && actualMember?.DeclaringType == null &&
-					actualMember?.Name == expectedOriginMember.Name)
-					return true;
-
-				return false;
+				return actualMember?.FullName == expectedOriginMember.FullName;
 			}
 		}