Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove popped trees more aggressively. (#31677)
When processing CEE_POP the importer sometimes created trees like ASG(tmp1, expr) followed by COMMA(ADDR(tmp1), NOP)) and that was causing some CQ issues. LocalAddressVisitor was then marking tmp1 as address-exposed and we never get rid of the dead ASG(tmp1, expr). What's worse, we then were adding a zero-initialization for tmp1 in the prolog. The fix here is to create a NOP instead of a COMMA is there are no side-effects in the first operand of the COMMA. This addresses the first example in #2325.
- Loading branch information